Repository navigation
fix: prevent adjacent lines leaking through reveal masks - #5
Open
saseungmin wants to merge 1 commit into
Open
saseungmin wants to merge 1 commit into
saseungmin wants to merge 1 commit into
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiline
lineReveal()animations could show fragments of the previous or next line inside another line's reveal window. Each mask translated a full paragraph copy, so its neighboring source lines could enter the visible band during positive or negative reveal offsets.Crop the intended measured line in a fixed-height, non-collapsible viewport before applying reveal translation. The existing outer frame still owns opacity, scale, pulse, and transform origin; paragraph shaping, accessibility, playback, and public APIs remain unchanged. This adds one native clipping View per rendered line.
Regression coverage
Seven tests follow glyph-band intervals through the actual rendered ancestor tree and clipping styles. They cover positive/negative offsets, large offsets, fractional line geometry, final visibility, and scale/pulse composition. They do not depend on a new wrapper test ID.
Validation
Documentation, interactive demos, and refreshed native recordings are maintained separately in #4. This PR contains only the renderer correction and its regression tests. Android rasterization was checked on the emulator above. Physical Android/iOS devices and other Android OS versions remain unverified. Temporary verification harness and source swaps were restored; this validation adds no source changes.