Skip to content

Fix uncontrolled multiline TextInput not resizing when children change #56291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janicduplessis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix uncontrolled multiline TextInput not resizing when children change #56291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4277c1c
Fix uncontrolled multiline TextInput not resizing when children change
janicduplessis Mar 31, 2026
17be3c9
Simplify React tree measurement fallback
janicduplessis Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...es/react-native/ReactCommon/react/renderer/components/textinput/BaseTextInputShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,20 @@ class BaseTextInputShadowNode
layoutContext.fontSizeMultiplier;
if (meaningfulState) {
const auto &stateData = BaseShadowNode::getStateData();

// State is synced with the React tree in `layout()`, after measurement. When
// `text` is empty and the children changed, `attributedStringBox` still holds
// the previous text, so measure the React tree instead.
if (BaseShadowNode::getConcreteProps().text.empty()) {
auto attributedString = getAttributedString(layoutContext);
if (!stateData.reactTreeAttributedString.isContentEqual(attributedString)) {
if (attributedString.isEmpty()) {
attributedString = getPlaceholderAttributedString(layoutContext);
}
return AttributedStringBox{attributedString};
}
}

auto attributedStringBox = stateData.attributedStringBox;
if (attributedStringBox.getMode() == AttributedStringBox::Mode::OpaquePointer ||
!attributedStringBox.getValue().isEmpty()) {
Expand Down
Loading