Stop framework headers from exposing private performance APIs - #58011
Open
coado wants to merge 4 commits into
Open
Stop framework headers from exposing private performance APIs#58011coado wants to merge 4 commits into
coado wants to merge 4 commits into
Conversation
Differential Revision: D109849952
Summary: Pull Request resolved: react#57312 This change rolls the umbrella-header + include-guard mechanism across the `react/renderer/components/*` modules, classifying each target as public, for-frameworks, or private. The change includes: - react/renderer/components/progressbar:androidprogressbar - `private`, - react/renderer/components/switch:androidswitch - `private`, - react/renderer/components/image:image - `public`, - react/renderer/components/inputaccessory:inputaccessory - `private`, - react/renderer/components/legacyviewmanagerinterop:legacyviewmanagerinterop - `private` - react/renderer/components/modal:modal - `public`, - react/renderer/components/text:text - `public`, - react/renderer/components/root:root - `public`, - react/renderer/components/safeareaview:safeareaview - `private`, - react/renderer/components/scrollview:scrollview - `public`, - react/renderer/components/unimplementedview:unimplementedview - `private`, - react/renderer/components/view:view - `public`, - react/renderer/components/virtualview:virtualview - `private`, - react/renderer/components/textinput:textinput - `for frameworks`, Changelog: [Internal] Differential Revision: D109316840
Differential Revision: D116298251
Summary: Move private performance includes out of framework-facing scheduler headers and into their implementation files. Store the conditional CDP reporters behind unique pointers so their declarations can remain private implementation details. Changelog: [Internal] Differential Revision: D116621742
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116621742. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move private performance includes out of framework-facing scheduler headers and into their implementation files. Store the conditional CDP reporters behind unique pointers so their declarations can remain private implementation details.
Changelog: [Internal]
Differential Revision: D116621742