Repository navigation
Set display density on prepared text layout paint (#59213) - #59213
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126198343. |
meta-codesync
Bot
changed the title
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 20, 2026
Summary: When prepared text layout is enabled, PreparedLayoutTextView draws the cached Layout directly. That Layout is built with a fresh TextPaint that never received the display density, so custom decoration drawing that scales with paint.density rendered wrong: the DOUBLE underline/linethrough gap (thickness + 2dp) collapsed to zero and the two strokes merged into one solid band. Changelog: [Android][Fixed] - Fix double text decorations rendering as a solid band when prepared text layout is enabled Differential Revision: D126198343
Abbondanzo
force-pushed
the
export-D126198343
branch
2 times, most recently
from
October 20, 2026 18:00
e82eb48 to
494a2a7
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 20, 2026
Summary: When prepared text layout is enabled, PreparedLayoutTextView draws the cached Layout directly. That Layout is built with a fresh TextPaint that never received the display density, so custom decoration drawing that scales with paint.density rendered wrong: the DOUBLE underline/linethrough gap (thickness + 2dp) collapsed to zero and the two strokes merged into one solid band. Changelog: [Android][Fixed] - Fix double text decorations rendering as a solid band when prepared text layout is enabled Differential Revision: D126198343
Summary: Pull Request resolved: react#59213 When prepared text layout is enabled, PreparedLayoutTextView draws the cached Layout directly. That Layout is built with a fresh TextPaint that never received the display density, so custom decoration drawing that scales with paint.density rendered wrong: the DOUBLE underline/linethrough gap (thickness + 2dp) collapsed to zero and the two strokes merged into one solid band. Changelog: [Android][Fixed] - Fix double text decorations rendering as a solid band when prepared text layout is enabled Differential Revision: D126198343
Abbondanzo
force-pushed
the
export-D126198343
branch
from
October 20, 2026 18:03
494a2a7 to
34dee24
Compare
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 6f6fa0a When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 6f6fa0a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When prepared text layout is enabled, PreparedLayoutTextView draws the cached Layout directly. That Layout is built with a fresh TextPaint that never received the display density, so custom decoration drawing that scales with paint.density rendered wrong: the DOUBLE underline/linethrough gap (thickness + 2dp) collapsed to zero and the two strokes merged into one solid band.
Changelog: [Android][Fixed] - Fix double text decorations rendering as a solid band when prepared text layout is enabled
Differential Revision: D126198343