Skip to content

Adopt renderer coalescing keys in Android Fabric - #59626

Draft
sorinc03 wants to merge 2 commits into
react:mainfrom
sorinc03:fix/android-fabric-event-coalescing-adoption
Draft

sorinc03 wants to merge 2 commits into
react:mainfrom
sorinc03:fix/android-fabric-event-coalescing-adoption

Conversation

@sorinc03

Copy link
Copy Markdown
Contributor

Summary

Part 2 of the split requested in #57074; depends on #57074 and relates to #54635.

Carries customCoalesceKey through Android Fabric event dispatch, pending view events, and JNI into the shared renderer. Removes the redundant compatibility overload from the internal EventEmitterWrapper and updates every caller.

This branch is stacked on the renderer-support commit from #57074. Until that dependency lands, GitHub's main-based diff includes the parent commit. The Android-only change is commit fe48881. Kept draft pending the core dependency and native CI. It will need rebasing onto main after the renderer change is imported.

Changelog

[ANDROID] [FIXED] - Respect custom coalescing keys for Fabric events on Android

Test Plan

JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home \
ANDROID_HOME=/Users/sorincioban/Library/Android/sdk \
./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest \
  --tests com.facebook.react.fabric.SurfaceMountingManagerEventOrderingTest \
  --tests com.facebook.react.fabric.events.FabricEventEmitterTest \
  -Preact.internal.useHermesNightly=false --console=plain

17 event-ordering tests and 1 emitter-forwarding test passed, 0 failures/errors. Changed Kotlin/C++ files pass formatting checks; git diff --check origin/main..HEAD passes.

Full JNI/C++ builds, renderer GTests, and device verification have not been run locally. Android C++ API snapshots were regenerated with CI-pinned Doxygen 1.16.1 before the clean rebase.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant