Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of the split requested in #57074; depends on #57074 and relates to #54635.
Carries
customCoalesceKeythrough Android Fabric event dispatch, pending view events, and JNI into the shared renderer. Removes the redundant compatibility overload from the internalEventEmitterWrapperand updates every caller.This branch is stacked on the renderer-support commit from #57074. Until that dependency lands, GitHub's main-based diff includes the parent commit. The Android-only change is commit
fe48881. Kept draft pending the core dependency and native CI. It will need rebasing onto main after the renderer change is imported.Changelog
[ANDROID] [FIXED] - Respect custom coalescing keys for Fabric events on Android
Test Plan
17 event-ordering tests and 1 emitter-forwarding test passed, 0 failures/errors. Changed Kotlin/C++ files pass formatting checks;
git diff --check origin/main..HEADpasses.Full JNI/C++ builds, renderer GTests, and device verification have not been run locally. Android C++ API snapshots were regenerated with CI-pinned Doxygen 1.16.1 before the clean rebase.