Skip to content

Compile out RCTViewManager under RCT_REMOVE_LEGACY_COMPONENT_INTEROP - WIP (#59651) #59651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −0
Open

Compile out RCTViewManager under RCT_REMOVE_LEGACY_COMPONENT_INTEROP - WIP (#59651) #59651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/React/Views/RCTComponentData.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#import <Foundation/Foundation.h>

#import <React/RCTComponent.h>
Expand Down Expand Up @@ -48,3 +50,5 @@ NS_ASSUME_NONNULL_BEGIN
RCT_EXTERN NSString *RCTViewManagerModuleNameForClass(Class managerClass);

NS_ASSUME_NONNULL_END

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
4 changes: 4 additions & 0 deletions packages/react-native/React/Views/RCTComponentData.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#import "RCTComponentData.h"

#import <objc/message.h>
Expand Down Expand Up @@ -550,3 +552,5 @@ - (void)setProps:(NSDictionary<NSString *, id> *)props forView:(id<RCTComponent>
}

@end

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
4 changes: 4 additions & 0 deletions packages/react-native/React/Views/RCTViewManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

typedef void (^RCTViewManagerUIBlock)(RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry);

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

@interface RCTViewManager : NSObject <RCTBridgeModule>

/**
Expand Down Expand Up @@ -119,3 +121,5 @@ typedef void (^RCTViewManagerUIBlock)(RCTUIManager *uiManager, NSDictionary<NSNu
CGFloat RCTJSONParseOnlyNumber(id json);

@end

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
4 changes: 4 additions & 0 deletions packages/react-native/React/Views/RCTViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#import "RCTViewManager.h"

#import "RCTAssert.h"
Expand Down Expand Up @@ -744,3 +746,5 @@ CGFloat RCTJSONParseOnlyNumber(id json)
}

@end

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
4 changes: 4 additions & 0 deletions packages/rn-tester/NativeComponentExample/ios/RCTInteropTestViewManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@

#import <React/RCTViewManager.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

NS_ASSUME_NONNULL_BEGIN

@interface InteropTestViewManager : RCTViewManager
@end
NS_ASSUME_NONNULL_END

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
4 changes: 4 additions & 0 deletions packages/rn-tester/NativeComponentExample/ios/RCTInteropTestViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#import "RCTInteropTestViewManager.h"
#import "RCTInteropTestView.h"

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

@implementation InteropTestViewManager

RCT_EXPORT_MODULE(InteropTestView)
Expand All @@ -18,3 +20,5 @@ - (UIView *)view
}

@end

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
4 changes: 4 additions & 0 deletions packages/rn-tester/NativeComponentExample/ios/RNTMyLegacyNativeViewManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#import "RNTMyNativeViewComponentView.h"
#import "UIView+ColorOverlays.h"

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

@interface RNTMyLegacyNativeViewManager : RCTViewManager

@end
Expand Down Expand Up @@ -86,3 +88,5 @@ - (NSDictionary *)constantsToExport
return @{@"PI" : @3.14};
}
@end

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
4 changes: 4 additions & 0 deletions packages/rn-tester/NativeComponentExample/ios/RNTMyNativeViewManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
#import <React/RCTViewManager.h>
#import "UIView+ColorOverlays.h"

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

@interface RNTMyNativeViewManager : RCTViewManager
@end

Expand Down Expand Up @@ -42,3 +44,5 @@ - (UIView *)view
}

@end

#endif // RCT_REMOVE_LEGACY_COMPONENT_INTEROP
Loading