Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fantom's tester is a Debug build, and in Debug
ReactInstanceConfigturns the inspector on by default, so every tester starts one even without--inspectorPort. With an inspector, the runtime scheduler's tasks wait until the inspector thread registers the runtime. If that thread is late,loadScriptdrains an empty queue,runtime_stays null, andloadScriptAndRunTestscrashes with SIGSEGV. It shows up when many testers run at once.This sets
enableInspector = falsein the tester's config, so the inspector only starts for--inspectorPort, as the code below it already expects.Fixes #59695
Changelog:
[INTERNAL] [FIXED] - Start the Fantom tester's inspector only for --inspectorPort
Test Plan:
Built the tester locally (macOS, M1 Pro), ran
View-itest.jsonce throughyarn fantomto get its bundle, then started 16 testers at once on that bundle with--featureFlags '{}' --minLogLevel error:main: 29 of 640 testers exited with SIGSEGV and no outputyarn fantom packages/react-native/Librariesalso passes (124 suites, 2149 tests).