Repository navigation
Remove sketchy-null lint disable (DOMRectReadOnly.js) (#59763) - #59763
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@jcperez-ch has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128806044. |
Summary: Pull Request resolved: react#59763 Drop `sketchy-null:off` from the file-level `flowlint` directive in `DOMRectReadOnly.js`, keeping `unsafe-getters-setters:off`. No code in the file triggers a sketchy-null lint (Flow reports nothing with the disable removed), so only the directive changes and runtime behavior is identical. Changelog: [Internal] Differential Revision: D128806044
jcperez-ch
force-pushed
the
export-D128806044
branch
from
November 2, 2026 15:56
975785e to
0bd0901
Compare
meta-codesync
Bot
changed the title
Collaborator
|
This pull request was successfully merged by @jcperez-ch in 6f05391 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Drop
sketchy-null:offfrom the file-levelflowlintdirective inDOMRectReadOnly.js, keepingunsafe-getters-setters:off. No code in the file triggers a sketchy-null lint (Flow reports nothing with the disable removed), so only the directive changes and runtime behavior is identical.Changelog: [Internal]
Differential Revision: D128806044