Skip to content

chore: ignore node_modules as a symlink too - #79

Merged
sunnylqm merged 1 commit into
masterfrom
chore/gitignore-node-modules
Aug 30, 2026
Merged

chore: ignore node_modules as a symlink too#79
sunnylqm merged 1 commit into
masterfrom
chore/gitignore-node-modules

Conversation

@sunnylqm

@sunnylqm sunnylqm commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

node_modules/ in .gitignore only matches a directory, so a node_modules symlink (e.g. pointing at another checkout from a git worktree) got committed in #74's history and broke CI's bun install with ENOENT: could not open the node_modules directory. Dropping the trailing slash ignores both the directory and a symlink.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JCaS35vZG4DCtmM24MYaVR


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated dependency-directory ignore rules to consistently exclude node_modules paths from version control.

`node_modules/` only matches a directory, so a `node_modules` symlink
(e.g. one pointing at another checkout from a git worktree) slipped into a
commit and broke CI's `bun install`. Drop the slash so both are ignored.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JCaS35vZG4DCtmM24MYaVR
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a69f7cdd-6539-4ee6-810d-803468eece48

📥 Commits

Reviewing files that changed from the base of the PR and between ee7cc34 and 0de258d.

📒 Files selected for processing (1)
  • .gitignore

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The .gitignore rule changed from node_modules/ to node_modules. The pattern now matches node_modules without requiring a trailing slash.

Changes

Dependency Ignore Pattern

Layer / File(s) Summary
Broaden dependency ignore rule
.gitignore
The ignore pattern changed from node_modules/ to node_modules.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0de25

This localized change broadens the .gitignore rule to cover both node_modules directories and symlinks; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the ignore rule so that node_modules symlinks are also ignored.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/gitignore-node-modules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sunnylqm
sunnylqm merged commit 2ddc2f8 into master Aug 30, 2026
5 checks passed
@sunnylqm
sunnylqm deleted the chore/gitignore-node-modules branch August 30, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant