Repository navigation
Document custom DOM data attributes - #947
Open
anmonteiro wants to merge 13 commits into
Open
anmonteiro wants to merge 13 commits into
anmonteiro wants to merge 13 commits into
Conversation
Use an erased DOM prop checker for typing and Merlin while emitting a single object constructor. Preserve identifier locations without duplicating complex expressions, restore the generated JavaScript snapshot, and cover nested JSX completion.
Hyphenate digits and underscores, and accept data-prefixed names while keeping standard data and datatype props on their existing DOM path. Update output snapshots, runtime coverage, and documentation.
Follow ml-in-barcelona/server-reason-react#412 for underscores, acronyms, and digits. Cover collisions between names after conversion.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the DOM data attributes introduced in #933 and link the updated guide from the JSX docs. Stacked on #933.
01a17001-efda-7320-8b10-3844e629533f