[dx] Deprecate ExplicitBoolCompareRector, as can make less readable if train - array and objects already handled by split rules - #8412
Merged
Conversation
TomasVotruba
force-pushed
the
deprecate-explicit-bool-compare
branch
from
August 29, 2026 22:20
1598dd7 to
d90e42d
Compare
Array and object bool compares have dedicated rules; the remaining behavior is an opinionated approach that depends on context. Replace the body with a deprecation message, remove its tests, and unregister it from the if set. Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
TomasVotruba
force-pushed
the
deprecate-explicit-bool-compare
branch
from
August 29, 2026 22:23
d90e42d to
1b10882
Compare
|
I'd like to keep this rule, opinionated maybe. Can't we keep the rule outside the if-set, as something that we can manually add to our rules? |
Member
Author
|
Ideally, use its version locally and fine tune to your needs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array and object bool compares have dedicated rules (
ArrayExplicitBoolCompareRector,ObjectExplicitBoolCompareRector); the remaining behavior is an opinionated approach that depends on context. Replace the body with a deprecation message, remove its tests, and unregister it from theifset.Part of splitting the if-set cleanup into focused PRs.