[dx] Move if-set rules into code-quality and coding-style sets, deprecate SetList::IF - #8414
Merged
Conversation
…cate SetList::IF Move rules that live in the CodeQuality and CodingStyle namespaces but were registered in the if set into their level sets: AlternativeIfToBracketRector and CompleteMissingIfElseBracketRector to CodingStyleLevel; InlineIfToExplicitIfRector, TernaryFalseExpressionToIfRector, ArrayExplicitBoolCompareRector, ObjectExplicitBoolCompareRector and ShortenElseIfRector to CodeQualityLevel. Deprecate SetList::IF, as the if set is being emptied. Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move rules that live in the
CodeQualityandCodingStylenamespaces but were registered in theifset into their level sets:AlternativeIfToBracketRector,CompleteMissingIfElseBracketRector->CodingStyleLevelInlineIfToExplicitIfRector,TernaryFalseExpressionToIfRector,ArrayExplicitBoolCompareRector,ObjectExplicitBoolCompareRector,ShortenElseIfRector->CodeQualityLevelDeprecate
SetList::IF, as the if set is being emptied (its remaining entries are deprecated rules handled in separate PRs).Part of splitting the if-set cleanup into focused PRs.