[CodeQuality] Skip same local method call chain in InlineIfToExplicitIfRector - #8418
Merged
Merged
Conversation
…IfRector
Extend the skip to flattened `&&`/`||` chains where every operand is a
`$this->foo(...)` call of the same name, e.g.
$this->validateExtensionAndMimeType($asset->getExtension(), $asset->loadFile())
&& $this->validateExtensionAndMimeType($this->parseExtension($asset->getTempName()), $asset->loadFile(true))
&& $this->validateExtensionAndMimeType($this->parseExtension($asset->getOriginalFileName()), null);
Claude-Session: https://claude.ai/code/session_01D93PXDaqua1utm7H8KyJAN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8417. Skip conversion when a flattened
&&/||chain has every operand as a$this->foo(...)method call of the same name.Reads better as a single expression than split into an explicit
if.