Skip to content

Add pull_request trigger to CI workflow - #340

Merged
marcelo-m-leite merged 1 commit into
v3-v2021-02-25from
update-ci-trigger
Aug 27, 2026
Merged

Add pull_request trigger to CI workflow#340
marcelo-m-leite merged 1 commit into
v3-v2021-02-25from
update-ci-trigger

Conversation

@douglasmiller

Copy link
Copy Markdown
Contributor

Summary

  • Add pull_request to the CI workflow trigger alongside push, so pull requests (including from forks) get CI runs that maintainers can approve directly from the PR's checks tab.
  • Scope the concurrency group by workflow name to avoid any cross-event collisions now that two event types feed the same workflow.

Why

Previously CI only ran on push, so PRs opened from forks had no workflow run to approve — the workaround was pushing the fork's commit to a local branch on this repo just to trigger CI. pull_request runs use the fork's code in an isolated context with no secrets, so this is safe to enable directly.

Test plan

  • Confirm CI runs automatically on this PR
  • Confirm a repo admin still sees an approval gate for outside-contributor PRs if "Fork pull request workflows require approval" is enabled in repo settings

🤖 Generated with Claude Code

Allow CI to run on pull requests, including those from forks, so
maintainers can approve and run checks without pushing the fork's
commit to a local branch first.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@douglasmiller douglasmiller added internal Internal tooling updates V6 v2021-02-25 Client labels Aug 27, 2026
@marcelo-m-leite
marcelo-m-leite merged commit 0b68270 into v3-v2021-02-25 Aug 27, 2026
24 of 26 checks passed
@marcelo-m-leite
marcelo-m-leite deleted the update-ci-trigger branch August 27, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal tooling updates V6 v2021-02-25 Client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants