Skip to content

Automated Sync from main to stable - #40

Open
rhods-devops-app[bot] wants to merge 639 commits into
stablefrom
main
Open

rhods-devops-app[bot] wants to merge 639 commits into
stablefrom
main

Conversation

@rhods-devops-app

@rhods-devops-app rhods-devops-app Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Automated Sync from main to stable

This PR automatically syncs the main branch to the stable branch by opening a pull request from main into stable.

Sync Summary

  • Latest commit: b7a5c6734 Merge remote-tracking branch 'upstream/main'

  • Total commits to sync: 639

  • Source: https://github.com/red-hat-data-services/OpenShell.git @ main

  • Target: https://github.com/red-hat-data-services/OpenShell.git @ stable

  • PR head: main

Commits to be synced

Merging

GitHub automerge is enabled for this pull request once required checks pass.

Comment thread .github/workflows/codex-security.yml Dismissed
Comment thread .github/workflows/release.yml Fixed
Comment thread .github/workflows/snap-publish.yml Dismissed
@rhods-devops-app
rhods-devops-app Bot enabled auto-merge October 24, 2026 01:13
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2d6c3115-2dd4-4b9b-9a04-10a1a980d49c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

Comment thread .github/workflows/release-auto-tag.yml Dismissed
Comment thread .github/workflows/release-prerelease.yml Dismissed
Comment thread .github/workflows/release.yml Dismissed
matthewgrossman and others added 2 commits November 3, 2026 02:09
…A#5078)

* test(e2e): run the testkit conformance suite in the host lanes

The Docker, Podman, Kubernetes and VM host lanes, including external-driver
mode and e2e:rust:push, now run the testkit `sandbox` package with nextest
instead of the old CLI conformance package. The tests find the lane's
gateway the same way the CLI does, through the OPENSHELL_GATEWAY_ENDPOINT
and OPENSHELL_GATEWAY values the gateway wrappers export, and `--no-tests
fail` makes a lane that selects no tests fail.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(conformance): delete the old CLI conformance suite

Nothing runs tests/suites/conformance/cli now that the host lanes run the
testkit suite. Remove it from the conformance workspace and its lockfile,
drop the e2e:testkit exclusion for it, and point the TESTING.md manual run
at the `sandbox` package.

e2e:rust:push also loses its dependency on e2e:conformance:build, which no
longer exists, and the unused OPENSHELL_CONFORMANCE_BIN it set.
crates/openshell-conformance stays for the features and drivers suites.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(e2e): drop the package filter from the host-lane conformance run

The conformance workspace has one package now that the old CLI suite is gone, so run the whole workspace.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* refactor(conformance): make the conformance family one crate

Conformance is one crate per family, so the family directory is the crate: tests/suites/conformance/sandbox becomes the `conformance` package at tests/suites/conformance, with its suites still in tests/. The workspace manifest path, its lockfile and the scripts that run it by path are unchanged.

Nextest's binaries for these tests are now `conformance::<suite>`; test names are unchanged. The tmachine runner rows, the fmt and clippy lines and the docs name the new package.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
matthewgrossman and others added 6 commits November 3, 2026 12:37
…VIDIA#5178)

* ci(e2e): preload Calico images into kind through the runner mirror

The app-listener lanes install Calico into kind. The kind node's
containerd pulled the Calico images from Docker Hub anonymously and
hit 429 Too Many Requests, failing all four lanes in kind setup.

Pull the images on the host instead, where the runner's Docker daemon
uses the nv-gha-runners Docker Hub mirror, and load them into kind
before applying the manifest. The image list comes from the manifest,
so a Calico upgrade cannot add an image that bypasses the preload.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* ci(e2e): preload a fixed list of Calico images

Name the three Calico images instead of extracting them from the
manifest, and define the Calico version once for both the manifest URL
and the image tags.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
)

Signed-off-by: Adrien Langou <alangou@nvidia.com>
* ci: publish stable protos to buf

Signed-off-by: Simon Scatton <sscatton@nvidia.com>

* ci: scope buf push to public protos

Signed-off-by: Simon Scatton <sscatton@nvidia.com>

---------

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
…ccepted (NVIDIA#4689)

The supervisor drops a session whose first frame is not SessionAccepted,
and the gateway registers a session before it acknowledges it. NVIDIA#4320
fixed the ordering by routing registry traffic through a private
channel whose forwarder starts only after the ack is queued, but
nothing tested it.

The new tests pause setup in its endpoint-status reset, open a relay on
the registered but unacknowledged session, and check that the stream
yields SessionAccepted and then the queued RelayOpen, in both poll and
push mode. With the test harness ported, the poll test fails on the code
before NVIDIA#4320.

Closes NVIDIA#4687

Signed-off-by: Emilien Macchi <emacchi@redhat.com>
* ci(release): publish stable Python wheels directly to PyPI

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

* test(release): remove publishing workflow shell tests

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

* ci(release): publish the PyPI wheel from the GitHub Release

Download the wheel and checksums from the stable GitHub Release instead of
the run's build artifact. A new Release run for the same tag rebuilds a
wheel whose bytes differ from the released asset, so publishing the run
artifact could not finish a failed PyPI upload after the artifact expired.

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

---------

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
* fix(sdk/go): set up Listen tunnels in parallel

Signed-off-by: Eric Curtin <eric.curtin@docker.com>

* test(sdk/go): cover EOF on abandoned setup

Signed-off-by: Eric Curtin <eric.curtin@docker.com>

---------

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
politerealism and others added 8 commits November 16, 2026 21:55
* test(conformance): port sandbox create --upload e2e tests to testkit

Move the three create_with_upload tests from e2e/rust into the conformance
suite. They read each uploaded file back and compare exact content, check the
nested file and that the directory is not flattened, and use the default
upload path and the target's default image. Remove the legacy test and its
now-unused SandboxGuard helpers.

Signed-off-by: Evan Lezar <elezar@nvidia.com>

* test(conformance): use expect_stdout for create-upload file checks

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Co-authored-by: Matthew Grossman <mgrossman@nvidia.com>
…ow (NVIDIA#5526)

* test(supervisor): cover a wait that loses its boundary transport twice

A supervisor wait recovers from one boundary transport loss, but after
that recovery a later loss on the replacement connection is reported as
"boundary lost during wait" without any reattach attempt, once the first
outage's 30s recovery window has passed.

Add a regression test that holds a wait open across two transport
aborts more than CONNECT_RETRY_TIMEOUT apart and expects the wait to
reattach both times and return the exit status. It fails on this
commit; the following commit fixes it.

Signed-off-by: mr-miles <miles.waller@gmail.com>

* fix(supervisor): give each boundary outage its own wait recovery window

call_wait_stream opened its 30s recovery window at the first transport
failure and never reset it. A wait lasts as long as the workload, so
after one successful recovery any later transport loss found the window
long expired and returned Unavailable without attempting a reattach.
BoundaryProcess::wait() then reported "boundary lost during wait" and
the supervisor exited, even though the boundary was still reachable.
accept_tcp shares the same path and stopped the proxy the same way.

Key the window by connection generation. A failure on a newer
generation means a recovery replaced the connection, so it starts a
fresh window. Repeated failures on one generation still share a single
bounded window, so a live connection whose streams keep failing does
not retry forever.

This makes wait_survives_a_second_transport_loss_after_recovery pass,
and adds unit tests for the per-generation window itself.

Signed-off-by: mr-miles <miles.waller@gmail.com>

---------

Signed-off-by: mr-miles <miles.waller@gmail.com>
…5609)

A gateway mutation record named the method and outcome of a delete but not
what it deleted, and a delete of a resource that was already gone looked the
same as one that removed it.

Delete records now list the selected workspace and the requested resource
by name, with the sandbox ID once a sandbox delete is accepted. A delete
that found nothing to remove records status_detail no_op:already_absent, and
an asynchronous sandbox delete records accepted. Rejected, cancelled, and
handler-denied deletes still name the requested resource.

Refs NVIDIA#2911

Signed-off-by: Kris Hicks <khicks@nvidia.com>
…nts (NVIDIA#5450)

* test(runner): pass an explicit per-test timeout and grace to program rows

Program rows relied on the program's 900 s default, so one hung test could use much of the 45-minute run timeout. Derive the per-test timeout from the same constants as the nextest profile (120 s) and pass it with a 10 s grace to the program.

Part of NVIDIA#5416.

Signed-off-by: Evan Lezar <elezar@nvidia.com>

* test(runner): keep program rows on the program's default timeout

Passing the runner's 120 s limit to the program would stop a test before
testkit's own step timeouts (up to 10 minutes) can report which step
stalled, contrary to the program's documented contract. Keep program rows
on the program's default until testkit learns the per-test deadline
(NVIDIA#5333).

Write nextest's grace period into the generated profile from the same
constants, rather than relying on nextest's default.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Co-authored-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
* fix(ci): let active dev releases finish

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

* fix(ci): preserve E2E cancellation outside dev releases

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

* docs(ci): shorten release concurrency guidance

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

* refactor(ci): make E2E cancellation a caller option

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

---------

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
moulalis and others added 20 commits November 17, 2026 04:07
…NVIDIA#5214)

* feat(observability): correlate HTTP receipts, audit records and traces

Closes NVIDIA#5393

Refs NVIDIA#5210

Signed-off-by: Alex Fournier <afournier@nvidia.com>

* fix(observability): narrow receipt validation and simplify tests

Signed-off-by: Alex Fournier <afournier@nvidia.com>

* refactor(observability): preserve per-control HTTP audit records

Correlate original control records at emission with a request-scoped ID and sequence. Remove primary-record aggregation and broad response-head validation while retaining protected receipts and request tracing.

Signed-off-by: Alex Fournier <afournier@nvidia.com>

* fix(observability): preserve HTTP correlation through relay failures

Avoid parsing queries solely for correlation. Carry request attribution through terminal errors and policy reloads, and clear HTTP scope at WebSocket upgrade.

Preserve per-control audit records while reporting bounded stage outcomes and filtering receipt trailers consistently. Remove JSON receipt additions and the unused correlation setter.

Signed-off-by: Alex Fournier <afournier@nvidia.com>

* fix(observability): finish stage results and isolate correlation fixtures

Signed-off-by: Alex Fournier <afournier@nvidia.com>

* fix(observability): report handled middleware stage failures

Signed-off-by: Alex Fournier <afournier@nvidia.com>

* fix(observability): complete proxy request correlation paths

Signed-off-by: Alex Fournier <afournier@nvidia.com>

---------

Signed-off-by: Alex Fournier <afournier@nvidia.com>
…licas (NVIDIA#5436)

* feat(supervisor): spread shared supervisors evenly across gateway replicas (closes NVIDIA#5434)

Signed-off-by: divesh <dgude@nvidia.com>

* fix(supervisor): redirect only hosts that accept a redirect

Signed-off-by: divesh <dgude@nvidia.com>

* fix(supervisor): count in-flight placements and keep handoff redirects after a redirect

Signed-off-by: divesh <dgude@nvidia.com>

* fix(supervisor): count every host a gateway keeps, including hosts that refuse redirects

Signed-off-by: divesh <dgude@nvidia.com>

* docs(supervisor): document best-effort gateway spreading

Signed-off-by: divesh <dgude@nvidia.com>

---------

Signed-off-by: divesh <dgude@nvidia.com>
* chore(deps): defer chrono advisory pending time API migration

Record RUSTSEC-2026-0543 for chrono 0.4.45. No patched release exists; replacing direct time APIs and transitive Kubernetes, OAuth2, and OCI consumers requires a coordinated migration. Keep all other cargo-deny policies unchanged.

Signed-off-by: Adrien Langou <alangou@nvidia.com>

* chore(deps): record crypto policy blocker for RSA advisory

russh 0.65.2 now accepts patched rsa 0.10.0, but rsa adds a mandatory hmac dependency outside the current wrapper policy. Retain RUSTSEC-2023-0071 until that policy change is reviewed and authorized, then upgrade and validate SSH and OIDC test-fixture consumers.

Signed-off-by: Adrien Langou <alangou@nvidia.com>

---------

Signed-off-by: Adrien Langou <alangou@nvidia.com>
* ci(e2e): build the Branch E2E deb without the VM driver

Add an include-vm-driver input to deb-package.yml (default true) and an
explicit OPENSHELL_DEB_OMIT_VM_DRIVER=1 opt-out in package-deb.sh, so
release builds still fail without the VM driver. Branch E2E builds its
deb without it and no longer waits for build-vm-driver-linux.

Run the deb job on hosted ubuntu-24.04 without the CI container. The
script only stages files and takes the target arch from
OPENSHELL_DEB_ARCH, so both architectures build on amd64.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* ci(e2e): keep the VM driver in every deb

Drop the include-vm-driver input and the OPENSHELL_DEB_OMIT_VM_DRIVER
opt-out so every caller builds the same deb. Most of the delay came from
the deb job's self-hosted runner queue and CI container start, which the
hosted runner already removes.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
…tions (NVIDIA#5611)

Mutation records for creates, updates, and lifecycle changes named no
resource, so an operator could not tell which sandbox was started, which
template was created, or which workspace member was added. A provider
attach that was already in place, a replayed request_id, and a profile
import that failed validation all looked like ordinary successful changes.

Hook the create, update, and lifecycle RPCs for sandboxes, templates,
services, provider attachments, provider profiles, workspaces, and rootfs
staging to record the workspace and the requested resources before the
call starts, completed with the name and ID of each resource the gateway
produced. Record no_op:unchanged and no_op:already_absent for attach and
detach calls that changed nothing, no_op:replayed for answers served from
a stored request_id result, and rejected:invalid_argument for provider
profile imports and updates that failed validation, including their
replays. A record lists at most 16 resources and counts the rest.

Refs NVIDIA#2911

Signed-off-by: Kris Hicks <khicks@nvidia.com>
…DIA#5635)

* feat(server): authenticate postgres with azure workload identity

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* docs(gateway): clarify azure postgres schema grants

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(server): reuse busy postgres sessions during entra outages

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* docs(server): clarify idle-session polling

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(postgres): preserve transport timeout error classification

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

---------

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.