Repository navigation
After opening the Kotlin class of the downloaded Maven dependency source code, I see a .class file instead of a .kt file #4297
Description
- After opening the Kotlin class of the downloaded Maven dependency source code, I see a
.classfile instead of a.ktfile. - Suppose I have a Kotlin class that references
com.facebook.presto.jdbc.internal.okhttp3.OkHttpClient. Now I hover my mouse over the textcom.facebook.presto.jdbc.internal.okhttp3.OkHttpClient, hold down theCtrlkey, and left-click. -
- At this point, I am accessing the
OkHttpClient.classfile ofcom.facebook.presto.jdbc.internal.okhttp3.OkHttpClient, not theOkHttpClient.ktfile. -
- I'm not entirely sure if this is expected behavior. I personally believe the title of this page should be
OkHttpClient.ktinstead ofOkHttpClient.class, because it displays the content of https://github.com/square/okhttp/blob/ace792f443b2ffb17974f5c0d1cecdf589309f26/okhttp/src/commonJvmAndroid/kotlin/okhttp3/OkHttpClient.kt , not the decompiled content. My current.vscode/settings.jsonfile contains the following:
{
"java.compile.nullAnalysis.mode": "automatic",
"java.jdt.ls.vmargs": "-XX:+UseParallelGC -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Dsun.zip.disableMemoryMapping=true -Xmx8G -Xms100m -Xlog:disable",
"java.jdt.ls.java.home": "~/.sdkman/candidates/java/25.0.1-graalce",
"java.configuration.runtimes": [
{
"name": "JavaSE-22",
"path": "~/.sdkman/candidates/java/22.0.2-graalce",
},
{
"name": "JavaSE-24",
"path": "~/.sdkman/candidates/java/24.0.2-graalce",
"default": true
},
{
"name": "JavaSE-25",
"path": "~/.sdkman/candidates/java/25.0.1-graalce",
},
],
}- Or am I misunderstanding something? For example, are there any VS Code plugins that specifically parse Kotlin files?
Activity
fbricon commentedon Jan 8, 2026
So because the class is coming from a jar, the java language server generates a link to the .class in that jar, which is then opened by vscode. At that point, we don't know whether the .class is associated to a source file, java or something else. And then on the client side (vscode) there's a hard-coded mapping from .class to java syntax highlighting. So if the source sent to vscode is kotlin, well, that doesn't look good.
I don't know if it's fixable. In theory, we would need to detect whether the source is attached in the 1st place during , identify which source that is, then compute a URI that both vscode and the language server could handle. But that would need to be done in several place and might be quite slow in certain circumstances.
fbricon commentedon Jan 8, 2026
It was actually super simple to do ;-)
open-proper-source.mp4
Now I need to fix all the unit tests that expected .class
fix 'Goto Super Implementation' test following redhat-developer#4297
fix 'Goto Super Implementation' test following #4297