Skip to content

Update language client to 10.1.0 - #4476

Open
datho7561 wants to merge 1 commit into
redhat-developer:mainfrom
datho7561:wip-update-languageclient
Open

Update language client to 10.1.0#4476
datho7561 wants to merge 1 commit into
redhat-developer:mainfrom
datho7561:wip-update-languageclient

Conversation

@datho7561

@datho7561 datho7561 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  • Update to vscode-langaugeclient@^10.1.0
  • Adjust to changes to language server logging API
    • VS Code now provides client-side log filtering based on a configured log level. This interacts in a slightly annoying way with our own server side log filtering, but ultimately both are helpful to have, since disabling logging on the client still means the server is sending trace level messages, which may be annoying.

Requires #4487 merged

Required to get workspace/textDocumentContent working, see eclipse-jdtls/eclipse.jdt.ls#3855

@datho7561 datho7561 changed the title [WIP] Update language client to 10.0.0 [WIP] Update language client to 10.1.0 Jul 29, 2026
@datho7561
datho7561 force-pushed the wip-update-languageclient branch 5 times, most recently from ab50010 to 2d2a745 Compare August 21, 2026 16:25
@datho7561 datho7561 changed the title [WIP] Update language client to 10.1.0 Update language client to 10.1.0 Aug 21, 2026
@datho7561
datho7561 force-pushed the wip-update-languageclient branch from 2d2a745 to f32b381 Compare August 21, 2026 16:26
Comment thread src/extension.ts Outdated
- Update to TypeScript 6 (TODO: split off into a different PR)
- Update to `vscode-langaugeclient@^10.1.0`
- Adjust to changes to language server logging API
  - VS Code now provides client-side log filtering based on a configured
    log level. This interacts in a slightly annoying way with our own
    server side log filtering, but ultimately both are helpful to have,
    since disabling logging on the client still means the server is
    sending trace level messages, which may be annoying

Required to get `workspace/textDocumentContent` working,
see eclipse-jdtls/eclipse.jdt.ls#3855

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
datho7561 force-pushed the wip-update-languageclient branch from f32b381 to 04d797a Compare August 21, 2026 16:29
@datho7561
datho7561 marked this pull request as ready for review August 21, 2026 17:27
@datho7561

Copy link
Copy Markdown
Contributor Author

@MeherSru if you have time, do you mind testing this? Specifically:

  1. Make sure that the regular vscode-java features work (errors, go to definition, hover, etc.)
  2. Check specifically that the jdt:// use case works. eg. links in hover Javadoc that point to classes in the JDK work properly (this is what you implemented for Add workspace/textDocumentContent request (#3852) eclipse-jdtls/eclipse.jdt.ls#3855)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant