Repository navigation
Conversation
Signed-off-by: rome-xi <rome-xi@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Makes sense, thanks for explaining. Happy for the issue author to take it, and feel free to reuse any of the tests here if they help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing vector set key or element is a nil reply. vEmbRaw() threw on RESP2 and RESP3 because its transform read reply[0]. On RESP2, vEmb() mapped the reply, vInfo() read reply.length, and vLinksWithScores() iterated it, so those threw as well. vLinks() already returned null.
The four transforms now return null for a nil reply. The vEmb() check lives in VEMB.ts rather than the shared double-array helper, which t-digest also uses. Reply types include null (NullReply on the RESP3 pass-through). Non-nil replies are unchanged.
Nil-reply cases sit in the existing command specs and call transformReply(null) on both protocols. They fail on master and pass with this change. npx tsc --noEmit -p packages/client is clean.
Fixes #3533
Note
Low Risk
Localized reply-transform and typing changes for vector-set commands; successful replies are unchanged and behavior matches Redis nil semantics.
Overview
Fixes nil replies for vector-set commands when a key or element is missing:
vEmb,vEmbRaw,vInfo, andvLinksWithScoresnow returnnullinstead of throwing during reply transforms (aligned with existingvLinks()behavior).VEMBwraps the shared double-array transformer with a local null guard so other consumers (e.g. t-digest) are unchanged. Reply typings now includenullon RESP2 and RESP3. Unit tests covertransformReply(null)and a compile-time types test guards issue #3533.Reviewed by Cursor Bugbot for commit e84e631. Bugbot is set up for automated code reviews on this repo. Configure here.