Repository navigation
Conversation
Keep published evaluator 2.0.0 and main's dependency updates, port ETag revalidation and initialization diagnostics to complete collections, preserve application-owned shutdown, and address the three Node migration review regressions. Keep OpenFeature and the v1 bootstrap demo isolated on published Node 1.8.3.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on Node SDK v2 adoption #790; this PR targets
feature/node-sdk-v2, notmain.evaluateAllshares results across roots; separate calls and contexts never share cached results.The 17-segment/two-root regression drops from 131,072 leaf comparisons to one per evaluation. Seven regression cases failed before the fix.
Validation
getFlagor two-root bootstrap call across alternating contexts, using mocked transport with no real network or telemetry.Scope and release boundary
@reflag/flag-evaluation@2.0.1; nothing is published by this PR. The separate Node prerelease workflow currently pins evaluator 2.0.0 and must deliberately adopt the published fixed evaluator before a prerelease can ship this fix. Workspace validation alone is not packed-release evidence.