Skip to content

fix(deps): bump basic-ftp, minimatch and addressable for dependency findings - #810

Merged
roncohen merged 1 commit into
mainfrom
chore/dep-security-bumps
Nov 19, 2026
Merged

roncohen merged 1 commit into
mainfrom
chore/dep-security-bumps

Conversation

@roncohen

Copy link
Copy Markdown
Contributor

Fixes the Oneleet dependency-scanning findings in this repo that have a compatible fixed version. All affected packages are development tooling or example apps; none ship in a published SDK.

Changes

Package Lockfile Before → after How
basic-ftp yarn.lock 5.3.1 → 6.2.6 Resolution get-uri@8.0.1 → 8.0.2 (patch). get-uri 8.0.2 depends on basic-ftp ^6.2.4. Chain: @openapitools/openapi-generator-cli → proxy-agent → pac-proxy-agent → get-uri, all pinned to exact versions, and the latest openapi-generator-cli still pins the same proxy-agent.
minimatch yarn.lock 10.2.5 → 10.2.6 Resolution minimatch@10.2.5 → 10.2.6 (patch). nx and @nx/devkit pin 10.2.5 exactly, including the latest nx.
minimatch packages/node-sdk/examples/cloudflare-worker/yarn.lock 9.0.8 → 9.0.9 yarn up -R. Also fixes the glob 10.5.0 finding there, which comes from this minimatch.
addressable packages/react-native-sdk/dev/bare-rn/Gemfile.lock 2.9.0 → 2.9.1 Edited by hand (no Ruby here): same runtime dependency (public_suffix >= 2.0.2, < 8.0), checksum from rubygems.org.

Not fixed here

These need a major-version upgrade of React Native or Expo tooling to fix, so they are left for a separate change:

  • image-size 1.2.1 (fixed in 2.0.3): from metro 0.83.3, pinned exactly by @expo/metro 54.2.0. metro 0.83.8 drops image-size.
  • fast-xml-parser 4.5.7 (fixed in 5.12.0): from @react-native-community/cli 20.0.0. CLI 21 uses fast-xml-parser 5.
  • uuid 7.0.3 (fixed in 11.1.1): from xcode 3.0.1 via @expo/config-plugins 54. xcode 4 drops uuid.
  • activesupport 7.2.3.1 in the bare-rn Gemfile.lock: the fix was released only for 8.0.5.2 and 8.1.4.1, and CocoaPods requires activesupport < 8.

Testing

  • yarn install --immutable passes.
  • Local yarn build stops at @reflag/management-sdk's OpenAPI generation because Java isn't installed on this machine; the generator CLI (the get-uri change) starts and runs up to the Java call. CI runs the full build and tests.

@reflag-review reflag-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low

no actionable findings

@roncohen
roncohen enabled auto-merge November 19, 2026 10:54
@roncohen

Copy link
Copy Markdown
Contributor Author

The findings listed under "Not fixed here" were marked Accepted risk in Oneleet on 2026-11-19: image-size 1.2.1 (CVE-2025-71329, CVE-2025-71330), fast-xml-parser 4.5.7 (CVE-2026-126066), uuid 7.0.3 (CVE-2026-41907) and activesupport 7.2.3.1 (CVE-2026-126080).

Reason: they are only in React Native / Expo development tooling and the bare-rn example app, not in any published SDK, and Oneleet rates each of them low risk. The fixed versions need a major React Native / Expo tooling upgrade, or in the case of activesupport, a version CocoaPods doesn't allow.

@roncohen
roncohen added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit e81c3fa Nov 19, 2026
9 checks passed
@roncohen
roncohen deleted the chore/dep-security-bumps branch November 19, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant