ENG-10963 feat(log): deprecate the legacy console logging helpers (5/5) - #6867
Conversation
Greptile SummaryThe PR deprecates the legacy console logging helpers while retaining their runtime rendering behavior.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/reflex-base/src/reflex_base/utils/console.py | Adds runtime and static deprecation markers while preserving the helpers’ legacy rendering paths. |
| tests/units/reflex_base/utils/test_log.py | Adds coverage for shim output and preservation of Rich rendering arguments. |
| packages/reflex-base/news/+eng-10963-console-deprecate.deprecation.md | Documents the deprecated helpers, replacements, and unaffected interactive console APIs. |
Reviews (8): Last reviewed commit: "feat(log): deprecate the legacy console ..." | Re-trigger Greptile
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3b76f45c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
a3b76f4 to
e79b135
Compare
816ef9a to
cf820d2
Compare
cf820d2 to
0c7dd29
Compare
console.debug/info/success/log/warn/error/timing now emit a runtime deprecation warning (removal in 1.0) and are marked with typing_extensions.deprecated for type-level warnings. Behavior is otherwise unchanged; the interactive Rich features (print/rule/ status/ask/progress) remain first-class.
0c7dd29 to
6b8e0a7
Compare
With every call site migrated,
console.debug/info/success/log/warn/error/timingnow emit a runtime deprecation warning (removal in 1.0) and are marked withtyping_extensions.deprecatedfor type-level warnings. Behavior is otherwise unchanged; the interactive Rich features (print/rule/status/ask/progress) remain first-class.This must land last: the deprecation markers only pass CI once no in-repo call site uses the helpers.
Stack (ENG-10963)
#6863 → #6864 → #6865 → #6866 → this.
Merge in order; each PR is based on the previous branch.