Skip to content

ENG-10963 feat(log): deprecate the legacy console logging helpers (5/5) - #6867

Open
FarhanAliRaza wants to merge 1 commit into
farhan/eng-10963-log-4-hosting-clifrom
farhan/eng-10963-log-5-deprecate-console
Open

ENG-10963 feat(log): deprecate the legacy console logging helpers (5/5)#6867
FarhanAliRaza wants to merge 1 commit into
farhan/eng-10963-log-4-hosting-clifrom
farhan/eng-10963-log-5-deprecate-console

Conversation

@FarhanAliRaza

@FarhanAliRaza FarhanAliRaza commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

With every call site migrated, console.debug/info/success/log/warn/error/timing now emit a runtime deprecation warning (removal in 1.0) and are marked with typing_extensions.deprecated for type-level warnings. Behavior is otherwise unchanged; the interactive Rich features (print/rule/status/ask/progress) remain first-class.

This must land last: the deprecation markers only pass CI once no in-repo call site uses the helpers.

Stack (ENG-10963)

#6863#6864#6865#6866 → this.
Merge in order; each PR is based on the previous branch.

Review in cubic

@FarhanAliRaza
FarhanAliRaza requested a review from a team as a code owner August 10, 2026 20:36
@linear-code

linear-code Bot commented Aug 10, 2026

Copy link
Copy Markdown

ENG-10963

@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR deprecates the legacy console logging helpers while retaining their runtime rendering behavior.

  • Adds runtime and type-level deprecation notices for the seven logging-shaped helpers.
  • Separates the legacy debug implementation so timing avoids a duplicate warning.
  • Adds release notes and regression coverage for output delegation and Rich keyword arguments.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/reflex-base/src/reflex_base/utils/console.py Adds runtime and static deprecation markers while preserving the helpers’ legacy rendering paths.
tests/units/reflex_base/utils/test_log.py Adds coverage for shim output and preservation of Rich rendering arguments.
packages/reflex-base/news/+eng-10963-console-deprecate.deprecation.md Documents the deprecated helpers, replacements, and unaffected interactive console APIs.

Reviews (8): Last reviewed commit: "feat(log): deprecate the legacy console ..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Aug 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 27 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing farhan/eng-10963-log-5-deprecate-console (6b8e0a7) with farhan/eng-10963-log-4-hosting-cli (af9cfbe)2

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on farhan/eng-10963-log-4-hosting-cli (ff238bf) during the generation of this report, so 291eee6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3b76f45c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/reflex-base/src/reflex_base/utils/console.py

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/reflex-base/src/reflex_base/utils/console.py
@FarhanAliRaza
FarhanAliRaza force-pushed the farhan/eng-10963-log-5-deprecate-console branch from a3b76f4 to e79b135 Compare August 12, 2026 10:37
@FarhanAliRaza
FarhanAliRaza force-pushed the farhan/eng-10963-log-5-deprecate-console branch 2 times, most recently from 816ef9a to cf820d2 Compare August 18, 2026 18:50
@FarhanAliRaza
FarhanAliRaza force-pushed the farhan/eng-10963-log-5-deprecate-console branch from cf820d2 to 0c7dd29 Compare August 18, 2026 21:37
console.debug/info/success/log/warn/error/timing now emit a runtime
deprecation warning (removal in 1.0) and are marked with
typing_extensions.deprecated for type-level warnings. Behavior is
otherwise unchanged; the interactive Rich features (print/rule/
status/ask/progress) remain first-class.
@FarhanAliRaza
FarhanAliRaza force-pushed the farhan/eng-10963-log-5-deprecate-console branch from 0c7dd29 to 6b8e0a7 Compare August 18, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant