Skip to content

ENG-11392: Update gradient profile shared component - #6913

Open
carlosabadia wants to merge 4 commits into
mainfrom
carlos/gradient-profile-local
Open

ENG-11392: Update gradient profile shared component#6913
carlosabadia wants to merge 4 commits into
mainfrom
carlos/gradient-profile-local

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review in cubic

@carlosabadia
carlosabadia requested a review from a team as a code owner August 19, 2026 08:43
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Aug 19, 2026
@linear-code

linear-code Bot commented Aug 19, 2026

Copy link
Copy Markdown

ENG-11392

@codspeed-hq

codspeed-hq Bot commented Aug 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 27 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing carlos/gradient-profile-local (a998fb7) with main (5194efc)2

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (2746068) during the generation of this report, so 5194efc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR replaces the external gradient-profile dependency with a packaged shared JavaScript component and resolves that asset lazily when the Python component is created.

  • Adds the local React gradient implementation.
  • Expands accepted seed values to UUIDs and supports custom libraries.
  • Adds shared-asset lifecycle and component-source tests.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/reflex-components-internal/src/reflex_components_internal/components/base/GradientProfile.js Adds the local memoized React component that deterministically derives and renders a two-color gradient.
packages/reflex-components-internal/src/reflex_components_internal/components/base/gradient_profile.py Migrates GradientProfile to a lazily resolved shared asset while preserving caller-supplied library overrides.
tests/units/reflex_components_internal/components/base/test_gradient_profile.py Adds coverage for lazy shared-asset resolution, library overrides, style composition, and decorative semantics.

Reviews (3): Last reviewed commit: "update" | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant