Skip to content

Avoid crashing listener on failed policy matching - #521

Merged
hluk merged 1 commit into
release-engineering:masterfrom
hluk:fix-listener-crash-on-policy-matching-error
Oct 30, 2026
Merged

hluk merged 1 commit into
release-engineering:masterfrom
hluk:fix-listener-crash-on-policy-matching-error

Conversation

@hluk

@hluk hluk commented Oct 30, 2026

Copy link
Copy Markdown
Member

An HTTP error while determining applicable policies for a subject, e.g. Koji rejecting an invalid NVR, crashed the listener. With the Kafka backend the message was never committed, so the listener kept crashing on it after every restart, blocking all messages behind it in the partition and failing to send decision updates.

Assisted-by: GLM 5.3

JIRA: RHELWF-14872

An HTTP error while determining applicable policies for a subject,
e.g. Koji rejecting an invalid NVR, crashed the listener. With the
Kafka backend the message was never committed, so the listener kept
crashing on it after every restart, blocking all messages behind it
in the partition and failing to send decision updates.

Assisted-by: GLM 5.3

JIRA: RHELWF-14872
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.28%. Comparing base (10859f9) to head (9df6d82).

Files with missing lines Patch % Lines
greenwave/tests/test_listeners.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   93.24%   93.28%   +0.03%     
==========================================
  Files          57       57              
  Lines        4711     4751      +40     
  Branches      300      300              
==========================================
+ Hits         4393     4432      +39     
- Misses        260      261       +1     
  Partials       58       58              
Flag Coverage Δ
unit-tests 93.28% <97.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hluk
hluk merged commit 92dbdeb into release-engineering:master Oct 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant