Repository navigation
Reject invalid NVR before calling Koji API - #522
Merged
hluk merged 1 commit intoNov 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 93.28% 93.37% +0.09%
==========================================
Files 57 57
Lines 4751 4772 +21
Branches 300 300
==========================================
+ Hits 4432 4456 +24
+ Misses 261 258 -3
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mvalik
reviewed
Oct 31, 2026
An invalid NVR, e.g. a bare package name like "pki-core", is rejected by Koji with an "invalid format" error. Reject such NVRs client-side instead, mirroring koji.parse_NVR() validation, to avoid a failing Koji request for every message about such subject. Assisted-by: GLM 5.3 JIRA: RHELWF-14872
hluk
force-pushed
the
reject-invalid-nvr-before-koji
branch
from
November 2, 2026 05:37
65df4fb to
3e5a00d
Compare
mvalik
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An invalid NVR, e.g. a bare package name like "pki-core", is rejected by Koji with an "invalid format" error. Reject such NVRs client-side instead, mirroring koji.parse_NVR() validation, to avoid a failing Koji request for every message about such subject.
Assisted-by: GLM 5.3
JIRA: RHELWF-14872