Repository navigation
chore(example): bump LVA, MDA contract_details schema versions - #1935
Open
gabrielseco wants to merge 1 commit into
Open
gabrielseco wants to merge 1 commit into
gabrielseco wants to merge 1 commit into
Conversation
Workbench-Thread: g-2026-11-11-bump-contract-details-LVA-MDA
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (317 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
Preview employmentsSeeded through https://remote-flows-ibb2v745r-remotecom.vercel.app. Each link opens onboarding with the employment prefilled: continue through Select Country and Basic Information to reach Contract Details. |
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 90.77% | 90.80% | -0.03% | 🔴 |
| Statements | 90.65% | 90.68% | -0.03% | 🔴 |
| Functions | 89.66% | 89.66% | 0% | ⚪ |
| Branches | 82.36% | 82.38% | -0.02% | 🔴 |
Detailed Breakdown
Lines Coverage
- Covered: 5930 / 6533
- Coverage: 90.77%
- Change: -0.03% (-2 lines)
Statements Coverage
- Covered: 6001 / 6620
- Coverage: 90.65%
- Change: -0.03% (-2 statements)
Functions Coverage
- Covered: 1578 / 1760
- Coverage: 89.66%
- Change: 0% (0 functions)
Branches Coverage
- Covered: 3688 / 4478
- Coverage: 82.36%
- Change: -0.02% (-1 branches)
✅ Coverage check passed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the pinned contract_details schema version in the example app for Latvia (LVA) and Moldova (MDA) from v1 to v6. Both countries now use the newer form engine, so they are added to the list of such countries, and a v6 baseline snapshot is added for each. A migration guide for each country is added and the README version matrix is updated; the guides cover v2 to v6 for partners with custom UIs. There is no public API change.
Decisions to review
Differences from the goal
Why
The example app pins Latvia and Moldova to v1, far behind the latest published contract_details schemas (v6), so the example does not exercise current onboarding forms for these countries.
What changed
Files and behaviour (9 files +822 −8)
docs/schema-changes/eor/contract-details/countries/LVA.md+138 −0docs/schema-changes/eor/contract-details/countries/MDA.md+132 −0docs/schema-changes/eor/contract-details/countries/README.md+2 −2example/src/flows/Onboarding/jsonSchemaVersions.ts+2 −2snapshots/contract-details/LVA.v6.json+265 −0snapshots/contract-details/MDA.v6.json+275 −0src/flows/Onboarding/tests/OnboardingFlowJobTitleEligibility.test.tsx+2 −2src/flows/Onboarding/tests/utils.test.ts+4 −2src/flows/Onboarding/utils.ts+2 −0Related Resources
Testing
Check: passed (exit 0, 2s)
Note
Low Risk
Documentation, example version pins, snapshots, and test/country-list updates only; no production API or auth changes.
Overview
Pins Latvia (LVA) and Moldova (MDA)
contract_detailsfrom v1 to v6 in the example app'sjsonSchemaVersionByCountry, and adds v6 baseline snapshots plus country migration guides (v2–v6) with an updated README version matrix.Both countries are added to
JSF_V1_CONTRACT_DETAILS_COUNTRIES, so onboarding uses the build-once / jsf v1 contract-details path for them. Tests that needed a non–jsf-v1 country now use Bolivia (BOL) instead of Latvia.No public API change—example pins, docs, snapshots, and internal country routing for the newer form engine.
Reviewed by Cursor Bugbot for commit 342bddd. Bugbot is set up for automated code reviews on this repo. Configure here.