Repository navigation
Include the fake CLI in Python source distributions - #160
Merged
Merged
Conversation
renezander030
enabled auto-merge (squash)
October 24, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python source archive includes
tests/test_client.pybut omitstests/fake_capcut.py, which the tests execute. Running the shipped tests from an unpacked archive therefore produces one failure and nine errors.Add
python/MANIFEST.inwithinclude tests/fake_capcut.pyso the existing test suite can run from the source archive.Validation: reproduced the missing fixture, rebuilt the source and wheel distributions, confirmed the fixture is included, and passed all 19 tests from the unpacked fixed archive and the source checkout on Python 3.13.5. The runtime module is byte-identical to the published 0.1.3 wheel. These tests use a fake CLI; they do not establish desktop compatibility.
The review reruns both the repository's Python CI command and an archive build/extract/test check before staging and again when publishing. Package publication is separate from this code review; the package version stays 0.1.3.