Skip to content

fix(github): set x-github-api-version - #45298

Open
RonaldPhilipsen wants to merge 3 commits into
renovatebot:mainfrom
RonaldPhilipsen:fix-41883-set-x-github-api-version
Open

fix(github): set x-github-api-version#45298
RonaldPhilipsen wants to merge 3 commits into
renovatebot:mainfrom
RonaldPhilipsen:fix-41883-set-x-github-api-version

Conversation

@RonaldPhilipsen

@RonaldPhilipsen RonaldPhilipsen commented Aug 15, 2026

Copy link
Copy Markdown

Changes

Explicitly sets the X-Github-API-Version header to 22-11-28 and define the constant so its easy to change in the future

The minimum GHES version that uses this API version is GHES3.7. but that has been EOL since 2024-01-04

Context

Please select one of the following:

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Use of AI in replying to PR comments

Who answers review comments:

  • @username will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@github-actions
github-actions Bot requested a review from viceice August 15, 2026 14:09
@cla-assistant

cla-assistant Bot commented Aug 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@viceice viceice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be problematic for older ghes versions. please update PR description with the required ghes version for that API

@RonaldPhilipsen

RonaldPhilipsen commented Aug 15, 2026

Copy link
Copy Markdown
Author

this can be problematic for older ghes versions. please update PR description with the required ghes version for that API

GHES3.7 already mentioned this api version in its docs, not sure which version is the lowest supported, updated the PR description

Comment thread lib/util/http/github.spec.ts Outdated
Co-authored-by: RahulGautamSingh <rahultesnik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(github): explicitly set X-GitHub-Api-Version: 2022-11-28

3 participants