Repository navigation
fix: prevent database loss when disk is full - #692
Merged
Merged
Conversation
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database saves previously truncated the existing database before writing its replacement, so running out of disk space could destroy all stored OTPs.
Write and sync the encrypted replacement to a temporary file in the same directory, then atomically replace the database. Preserve existing permissions and symlink targets, clean up temporary files on failure, and include the underlying error in save failures. Only clear the modified flag after a successful save.
Add regression coverage for failed writes, successful replacement, permissions, and symlinks. A CLI test forces a partial write failure and verifies the original database is unchanged and its OTP remains readable. Existing add tests now use isolated database copies.
Closes #691.
Validation:
cargo test --locked— 50 tests passedcargo test --locked --release— 50 tests passedcargo fmt --all -- --checkcargo clippy -- -D warnings