Repository navigation
Conversation
# Conflicts: # src/arguments/mod.rs # src/main.rs
# Conflicts: # src/arguments/mod.rs # src/main.rs
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand cotp's CLI authentication workflows and protect vault changes across processes. Code generation now supports unambiguous account selection, structured output, validity thresholds, watch mode, and noninteractive password input. HOTP counters are persisted before codes are returned.
ykman.Features were developed in independent worktrees and merged into this feature branch. See the implementation inventory for branch coverage and deliberate boundaries.
Validation
Passed locally on Linux aarch64:
Each Rust configuration passed 120 unit tests and 24 integration tests. The ignored cross-process locking helper is invoked explicitly by its parent test. All four Python converter tests passed.
Compatibility and verification limits
Plaintext export requires explicit consent; read-only commands do not create a missing vault. Account indexes are one-based and ambiguous selectors fail. Vault schema migration adds persistent account metadata.
Snapshot exchange is explicit and local; HOTP counter merging does not make concurrent offline generation safe. Native clipboard expiration is best effort, and OSC52 copies cannot be cleared with an ownership check.
macOS, Windows, physical YubiKeys, native credential stores, and the release attestation workflow were not exercised locally. Backend tests use fixtures and mocks.