Repository navigation
Pin restate-sdk-shared-core to the merge commit of its cloud/tunnel features - #260
Closed
slinkydeveloper wants to merge 1 commit into
Closed
slinkydeveloper wants to merge 1 commit into
slinkydeveloper wants to merge 1 commit into
Conversation
…eatures The branch the patch pointed at was deleted on merge. Pinned to the commit on main until a shared core release carries the `cloud_keys` and `tunnel` features, after which the patch section goes away. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the move of the restate-sdk-shared-core git patch from the deleted cloud-exp-revamp branch to a pinned upstream revision.
[patch.crates-io]pin —Cargo.tomlnow points atrev = "3ccd488". The upstream PR page for restatedev/sdk-shared-core#108 confirms this is its merge commit intomain.- Lockfile source —
Cargo.locknow records the full3ccd488feae66314142003e1e2c46b4f364cafd9and keeps version8.3.0. The previous lock pinned7fbd30d. The only later commit in the upstream PR,0d0adb7, changes nothing but a doc comment insrc/cloud_keys.rs, so behavior stays the same.
I ran cargo metadata --locked and cargo check --locked on the PR head. Both passed, so the lockfile matches the new pin and the crate builds against it with the tunnel/rust_crypto/request_identity/sha2_random_seed features.
claude-opus-5-5 ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[patch.crates-io]entry from #258 pointed at thecloud-exp-revampbranch of sdk-shared-core, which GitHub deleted when restatedev/sdk-shared-core#108 was merged, so main cannot resolve the dependency. This pins the same code by its merge commit on sdk-shared-core main (3ccd488). Once a shared core release carries thecloud_keysandtunnelfeatures, the patch section goes away and the version bumps.🤖 Generated with Claude Code