Skip to content

Few touchups - #261

Merged
slinkydeveloper merged 2 commits into
mainfrom
prep-release
Nov 4, 2026
Merged

slinkydeveloper merged 2 commits into
mainfrom
prep-release

Conversation

@slinkydeveloper

Copy link
Copy Markdown
Contributor

No description provided.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues. Two README inconsistencies to look at, both inline.

Reviewed changes

Reviewed the release-prep touchups: the dependency bump and the README rewrite.

  • Use crates.io restate-sdk-shared-core 8.3.0: drops the [patch.crates-io] git override for branch cloud-exp-revamp. The lock checksum matches the crates.io release, and in 8.3.0 the tunnel feature turns on cloud_keys, which src/tunnel.rs imports.
  • README: ASGI serving section: new Hypercorn examples for the CLI and for starting from code, plus a registration hint.
  • README: Cloud connect and clients: rewords the connect instructions, adds Cloud UI deep links, and adds a ### Clients subsection.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No new issues. The connect-name mismatch is fixed. The earlier ### Clients comment (missing RESTATE_INGRESS_KEY, Configure SDK vs Configure Client) and the trailing-whitespace nit still apply.

Reviewed changes

Reviewed what changed between f1d6223 and 70e824d.

  • Consistent connect name: the CLI flag, the connect://greeter-v1 registration line, restate.connect(...) and restate.with_connection(...) all use greeter-v1 now.

Pullfrog  | Fix it ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No new commits. One README point from an earlier thread still applies, and it's posted inline.

Reviewed changes

No commits have landed since 70e824d. This run re-checked the threads that were resolved without a code change or a reply.

  • Trailing whitespace and Cloud UI page name: not raised again. The whitespace is cosmetic, and the author may know the revamped Cloud UI better than the client.py docstrings do.
  • ### Clients env var: raised again. The README still never names RESTATE_INGRESS_KEY.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

Comment thread README.md Resolved
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Test Results

  8 files    8 suites   3m 36s ⏱️
 71 tests  71 ✅ 0 💤 0 ❌
322 runs  322 ✅ 0 💤 0 ❌

Results for commit 70e824d.

Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found. The last open README point is addressed.

Reviewed changes

Reviewed what changed between 70e824d and e2a3289.

  • Named the ingress key env var: the ### Clients section now says restate.create_client() reads the key from RESTATE_INGRESS_KEY. That matches what resolve_ingress in python/restate/client.py reads.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@slinkydeveloper
slinkydeveloper merged commit f131112 into main Nov 4, 2026
10 checks passed
@slinkydeveloper
slinkydeveloper deleted the prep-release branch November 4, 2026 15:55
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant