Repository navigation
Few touchups - #261
Few touchups#261
Conversation
f1d6223 to
70e824d
Compare
There was a problem hiding this comment.
ℹ️ No critical issues. Two README inconsistencies to look at, both inline.
Reviewed changes
Reviewed the release-prep touchups: the dependency bump and the README rewrite.
- Use crates.io
restate-sdk-shared-core8.3.0: drops the[patch.crates-io]git override for branchcloud-exp-revamp. The lock checksum matches the crates.io release, and in 8.3.0 thetunnelfeature turns oncloud_keys, whichsrc/tunnel.rsimports. - README: ASGI serving section: new Hypercorn examples for the CLI and for starting from code, plus a registration hint.
- README: Cloud connect and clients: rewords the connect instructions, adds Cloud UI deep links, and adds a
### Clientssubsection.
claude-opus-5-5 | 𝕏
There was a problem hiding this comment.
ℹ️ No new issues. The connect-name mismatch is fixed. The earlier
### Clientscomment (missingRESTATE_INGRESS_KEY, Configure SDK vs Configure Client) and the trailing-whitespace nit still apply.
Reviewed changes
Reviewed what changed between f1d6223 and 70e824d.
- Consistent connect name: the CLI flag, the
connect://greeter-v1registration line,restate.connect(...)andrestate.with_connection(...)all usegreeter-v1now.
claude-opus-5-5 | 𝕏
There was a problem hiding this comment.
ℹ️ No new commits. One README point from an earlier thread still applies, and it's posted inline.
Reviewed changes
No commits have landed since 70e824d. This run re-checked the threads that were resolved without a code change or a reply.
- Trailing whitespace and Cloud UI page name: not raised again. The whitespace is cosmetic, and the author may know the revamped Cloud UI better than the
client.pydocstrings do. ### Clientsenv var: raised again. The README still never namesRESTATE_INGRESS_KEY.
claude-opus-5-5 | 𝕏
Test Results 8 files 8 suites 3m 36s ⏱️ Results for commit 70e824d. |
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
There was a problem hiding this comment.
✅ No new issues found. The last open README point is addressed.
Reviewed changes
Reviewed what changed between 70e824d and e2a3289.
- Named the ingress key env var: the
### Clientssection now saysrestate.create_client()reads the key fromRESTATE_INGRESS_KEY. That matches whatresolve_ingressinpython/restate/client.pyreads.
claude-opus-5-5 | 𝕏

No description provided.