Repository navigation
feat(head-turn): re-bake the head-turn demo on the confirmed depth atlas - #85
Merged
Merged
Conversation
The head-turn demo moves each vertex by its sampled depth. Those depths are now read from the revised depth atlas the owner confirmed (same 1992x2000 layout). Only the depth data changes: the app, runtime, aperture, colour atlas, UI and curvature page are byte-unchanged. Control first: the old atlas, run through the same reader, extractor, dedup and `gzip.compress(level 9, mtime 0)`, reproduces the shipped scene.bin.gz and scene.json byte for byte. The compressor invocation is reproduced, not recovered from a log. The new atlas then gives a 3,405,993-byte geometry asset. All 19 parts keep their 224,144 ordered triangles, positions, UVs and drivers exactly; dedup stores 132,540 vertices (6 depth-tuple splits, no topology change). bun test src/head-turn.test.ts: 6 pass, including mutation and manifest negatives. Site test, build and verify: 35 pass. In Chromium the neutral canvas is byte-identical to the old one, yaw and pitch change as intended, and there are no console errors. Closes #84 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
HQ: Checks are green. The AI review has shown "running" for more than 30 minutes since this PR opened, so this merges on Checks per the review-wait rule. A late review finding would be handled in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The head-turn demo moves each vertex by its sampled depth. Those depths
are now read from the revised depth atlas the owner confirmed (same
1992x2000 layout). Only the depth data changes: the app, runtime,
aperture, colour atlas, UI and curvature page are byte-unchanged.
Control first: the old atlas, run through the same reader, extractor,
dedup and
gzip.compress(level 9, mtime 0), reproduces the shippedscene.bin.gz and scene.json byte for byte. The compressor invocation is
reproduced, not recovered from a log. The new atlas then gives a
3,405,993-byte geometry asset. All 19 parts keep their 224,144 ordered
triangles, positions, UVs and drivers exactly; dedup stores 132,540
vertices (6 depth-tuple splits, no topology change).
bun test src/head-turn.test.ts: 6 pass, including mutation and manifest
negatives. Site test, build and verify: 35 pass. In Chromium the neutral
canvas is byte-identical to the old one, yaw and pitch change as
intended, and there are no console errors.
Closes #84
🤖 Generated with Claude Code