Repository navigation
Throw std::invalid_argument when empty key is used - #11
Merged
Merged
Conversation
rigtorp
force-pushed
the
feat/throw-on-empty-key
branch
2 times, most recently
from
November 14, 2026 17:37
ac2b97d to
3ff828e
Compare
rigtorp
force-pushed
the
feat/throw-on-empty-key
branch
from
November 14, 2026 17:39
3ff828e to
c002215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asserton empty key inemplace_implandfind_implwith a[[unlikely]]check calling a[[noreturn]]noinlinedetail::throw_empty_key()helper<cassert>includesrc/HashMapTest.cppcoveringinsert,emplace,operator[],find,count,at, anderasewith the empty keyREADME.mdTest plan
clang-format --dry-run --Werror include/rigtorp/HashMap.h src/*.cppcmake --build --preset debug --parallel && ctest --preset debugcmake --build --preset release --parallel && ctest --preset release