Repository navigation
Modernize and simplify CMake build and CI - #8
Merged
Merged
Conversation
rigtorp
force-pushed
the
build/simplify-cmake-and-ci
branch
from
November 14, 2026 17:08
e199686 to
705dea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FILE_SET HEADERSandCOMPILE_WARNING_AS_ERRORCMakeLists.txtto gate tests/examples/benchmark/install onPROJECT_IS_TOP_LEVELand exportHashMapConfig.cmakedirectly (removingcmake/HashMapConfig.cmake.in)CMakePresets.jsonand ignoreCMakeUserPresets.jsonin.gitignore-Wshadow,-Wconversion,-Wold-style-cast,-Wundefon GCC/Clang;/w14242on MSVC) and fix-Wshadowwarnings insrc/HashMapTest.cppandsrc/HashMapBenchmark.cpp.github/workflows/ci.ymlto use the sharedcpp-ci.ymlworkflow and remove obsoletetests/cmake/*and.github/workflows/ccpp.ymlREADME.mdbuild instructionsTest plan
cmake --preset debug && cmake --build --preset debug --parallel && ctest --preset debugcmake --preset release && cmake --build --preset release --parallel && ctest --preset release