Skip to content

Modernize and simplify CMake build and CI - #8

Merged
rigtorp merged 1 commit into
masterfrom
build/simplify-cmake-and-ci
Nov 14, 2026
Merged

rigtorp merged 1 commit into
masterfrom
build/simplify-cmake-and-ci

Conversation

@rigtorp

@rigtorp rigtorp commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • Require CMake 3.24+ and use FILE_SET HEADERS and COMPILE_WARNING_AS_ERROR
  • Simplify CMakeLists.txt to gate tests/examples/benchmark/install on PROJECT_IS_TOP_LEVEL and export HashMapConfig.cmake directly (removing cmake/HashMapConfig.cmake.in)
  • Add CMakePresets.json and ignore CMakeUserPresets.json in .gitignore
  • Enable stricter compiler warnings (-Wshadow, -Wconversion, -Wold-style-cast, -Wundef on GCC/Clang; /w14242 on MSVC) and fix -Wshadow warnings in src/HashMapTest.cpp and src/HashMapBenchmark.cpp
  • Update .github/workflows/ci.yml to use the shared cpp-ci.yml workflow and remove obsolete tests/cmake/* and .github/workflows/ccpp.yml
  • Update README.md build instructions

Test plan

  • cmake --preset debug && cmake --build --preset debug --parallel && ctest --preset debug
  • cmake --preset release && cmake --build --preset release --parallel && ctest --preset release

@rigtorp
rigtorp force-pushed the build/simplify-cmake-and-ci branch from e199686 to 705dea0 Compare November 14, 2026 17:08
@rigtorp
rigtorp merged commit 3ef8062 into master Nov 14, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant