Port GSA authentication fixes (AltSign PRs #50/#51) to Windows - #51
Closed
shanegillio wants to merge 1 commit into
Closed
Port GSA authentication fixes (AltSign PRs #50/#51) to Windows#51shanegillio wants to merge 1 commit into
shanegillio wants to merge 1 commit into
Conversation
…stut#51 to Windows - Use AuthKit/1 user agent instead of 2019-era akd/1.0 CFNetwork string - Retry GSA requests up to 5 times on HTTP 5xx with 1/2/4/8s backoff, using a fresh http_client per attempt to avoid Apple's edge pinning a failing backend connection - Surface HTTP status, Content-Type, and body snippet when Apple returns a non-plist response instead of a bare InvalidResponse error - Route trusted-device 2FA verify response through the same validation Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the GSA sign-in fixes from rileytestut/AltSign#50 and rileytestut/AltSign#51 to AltServer for Windows. The macOS versions were confirmed working against the recent GSA 503 / error-3840 sign-in failures; the Windows code has the same blind spots, so it presumably fails the same way.
Changes (all in
AltSign/AppleAPI+Authentication.cpp)akd/1.0 CFNetwork/978.0.7 Darwin/18.7.0string withAuthKit/1 (Macintosh; OS X 26.5.2) (com.apple.dt.Xcode/26.0), matching AltSign PR Port GSA authentication fixes (AltSign PRs #50/#51) to Windows #51.SendAuthenticationRequestnow retries up to 5 times with 1/2/4/8s backoff. Each attempt constructs a freshhttp_client— the cpprestsdk equivalent of the ephemeralURLSessionin PR Hello, after upgrading to version 26.4 and installing it via a self-signed installer, the app crashes. What could be the reason? #50 — because Apple's GSA edge pins a keep-alive connection to a backend node, and once that node starts 5xx-ing, retries on the same connection never recover.LocalizedAPIErrorinstead of a bareAPIErrorCode::InvalidResponse.Notes for review
1.7.4branch (hence the base). Happy to rebase elsewhere if there's a better target.X-Mme-Client-Infoto a native Windows AuthKit client ID, while the new User-Agent identifies as Xcode on a Mac. If the patched build still hits 503s, that mismatch is the first thing worth investigating.🤖 Generated with Claude Code