Skip to content

torch: small cleanup - #275

Open
luhenry wants to merge 1 commit into
mainfrom
torch
Open

torch: small cleanup#275
luhenry wants to merge 1 commit into
mainfrom
torch

Conversation

@luhenry

@luhenry luhenry commented Aug 19, 2026

Copy link
Copy Markdown
Member

Reduce implicit equivalence between PYTORCH_FINAL_PACKAGE_DIR and ${{ runner.temp }}/artifacts.

@threexc

threexc commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Looks like the builds are looking in the wrong place for patches. I see patches/torch/2.13.0+cpu locally, but patches/torch/2.13.0 in the failed jobs.

@luhenry

luhenry commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

#246 (comment)

@threexc do you want to push to that branch directly?

@threexc

threexc commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

#246 (comment)

@threexc do you want to push to that branch directly?

I'll push to it in a moment.

@justeph

justeph commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@luhenry I found the issue, do you want me to push a fix in torch branch directly?

@justeph

justeph commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@luhenry I am not sure about what you are trying to clean.. Maybe it deserve a better commit title and/or a commit message to explain what you are doing? it's difficult to review as-is

@threexc

threexc commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@luhenry I found the issue, do you want me to push a fix in torch branch directly?

fix here: #276

@luhenry luhenry closed this Aug 20, 2026
@luhenry luhenry reopened this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants