Repository navigation
Conversation
Drops the hardcoded version/python matrix (and its per-version 9.1.1 cp313/cp314 exclude, now naturally covered by docs/packages/thinc.yaml's own files: list) in favor of the setup job's generated include: matrix. docs/packages/thinc.yaml also declares musllinux files for both pending versions, which the old manylinux-only job never built; this starts building those too.
No libc dimension (docs/packages/vtk.yaml has no musllinux entries), so this stays manylinux-only; only the strategy.matrix block changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide migration off hardcoded
strategy.matrixpython/libc arraysonto the
setupjob's generatedoutputs.matrix(see CLAUDE.md / PRs #4914, #4915).Packages in this batch, each as its own commit:
For each file: the
build_wheelsjob'sstrategy.matrixnow readsinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}instead of its ownhardcoded
version/python(/libc) arrays, and every remaining${{ matrix.libc }}reference (jobname:,CIBW_BUILD/only:,CIBW_BEFORE_ALL_LINUX, artifactname:) was renamed to${{ matrix.platform }}.matrix.pythonandmatrix.versionare unchanged.None of the
publishjobs referencedmatrix.libc.Pre-existing stale/incomplete matrix issues found (fixed as a side effect of
this structural change):
turbohtmlandtype-enforcedhad ahardcoded
python:list that starts atcp312, whiledocs/packages/<pkg>.yaml'sfiles:entries for the currently pendingversion(s) also call for
cp310/cp311(and, where applicable,cp315/cp315t). Those older/newer interpreters were never being built.(
turbohtmlandtype-enforcedcurrently have no pending version, buttheir hardcoded lists exactly match the latest released version's
files:, so there's nothing to fix there.)thinc: the old job hardcodedpython: ["cp312","cp313","cp314"]with amanual
exclude:droppingcp313/cp314for 9.1.1.9.1.1's ownfiles:list indocs/packages/thinc.yamlnever declaredcp313/cp314in the first place, so the generated matrix naturally omits them - the
manual exclude was redundant and is dropped. Separately,
docs/packages/thinc.yamldeclaresmusllinuxfiles for both pendingversions (9.1.1 and 10.0.0) that the old manylinux-only job never built;
this PR starts building those for the first time (added
MUSLLINUX_RISCV64_IMAGE/CIBW_MUSLLINUX_RISCV64_IMAGE, parameterized thejob name/
only:/artifact name on${{ matrix.platform }}, and widened thepublish
artifact-patternfrom*-manylinux_riscv64to*riscv64).webrtcvad-wheelsandyara-python: the old hardcoded lists includedcp314/cp314t, but neither package's currently pending version actuallydeclares
cp314/cp314tfiles in itsdocs/packages/*.yaml(upstreamdoesn't publish those wheels for these older releases) - those legs were
being built unnecessarily/incorrectly. The generated matrix now builds
exactly what's declared.
vtk:docs/packages/vtk.yamlhas nomusllinuxentries for any pendingversion, so this one stays manylinux-only; only the
strategy.matrixblock itself changes. Flagging per the task note that VTK's build is
unusually large/complex (48h timeout, custom CMake/podman build, a
same-leg SDK-packaging step gated on
matrix.python == 'cp312') - Iverified the matrix shape is otherwise standard (just
version+python, nolibc, same asthinc) and found nothing non-standardbeyond that, but called it out explicitly rather than guessing given its
size.
No changes to
docs/packages/*.yaml,.queue.yml, orskills/in this branch.Not waiting on this PR's CI to go green before reporting back.