Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the
build_wheelsjob'sstrategy.matrixin 14 workflows from ahardcoded
python/libcarray toinclude: ${{ fromJSON(needs.setup.outputs.matrix) }},and renames the remaining
matrix.libcreferences tomatrix.platform(jobname:, cibuildwheelonly:/CIBW_BUILD, artifactname:). Same shape as#4914/#4915.
Packages touched: fastcdc, faster-fifo, gemmi, gimli.units, glcontext, gpiod,
guppy3, hdrhistogram, igwn-segments, imgui-bundle, immutables, islpy,
jsonobject, kaldialign.
Verified each conversion with
uv run ci_scripts/pending_versions.py --python-matrix --python-exclude cp39 <pkg>against the old hardcodedpython/libc lists. Findings:
pre-existing stale-matrix bug, same class as mocpy: drop 3.9/3.10 and musllinux from the 0.20.0 matrix #4914/phono3py: exclude cp310/cp311, phonopy/spglib have no wheel there #4915. The old hardcoded
list omitted cp310/cp311 (genuinely declared in each package's YAML for the
pending version) while hardcoding cp314/cp314t (not declared at all for that
version). This PR's structural fix corrects it as a side effect.
islpy, cp315) were never attempted even though the YAML declares them for
the pending version(s).
though declared; fixed as a side effect.
matched the generated matrix exactly for the pending 0.10.8 version — no
behavior change.
gotcha 127: upstream ships no cp314t wheel, but the extension just
re-enables the GIL on import rather than failing).
docs/packages/igwn-segments.yamldeclares no 3.14t entries at all, so the generated matrix drops that leg;
restoring it needs a YAML change, which is out of scope here (not touching
docs/packages/*.yamlin this branch). cp310/cp311 were also never attempteddespite being declared — fixed as a side effect.
repo's numpy-driven cp312 floor"), and
docs/packages/imgui-bundle.yamldoesdeclare 3.11 entries, so converting to the generated matrix would have
silently started building cp311 again. Added
python-exclude: 'cp39 cp311'to the
setup:job'swith:block to preserve the intentional exclusion.Also note cp315 now builds for version 1.93.0, which the old list never
covered.
matrix to compare against today; the structural fix is otherwise a no-op
until a new version lands. The free-threaded exclusion comment was reworded
since
docs/packages/guppy3.yamlsimply declares no 3.1[34]t entries (nopython-excludechange needed).No files outside
.github/workflows/*were touched.