Repository navigation
Conversation
All three still hard-coded their own python/libc matrix in build_wheels, duplicating docs/packages/<pkg>.yaml and drifting out of sync with it - the exact bug already fixed once for each of these three in now-closed PRs #4911/#4912/#4913 (stale lists missing cp310/cp311/cp315). Converting to needs.setup.outputs.matrix (the pattern most other build-<pkg>.yml files already use) fixes the coverage gap structurally instead of by widening a second, independently-maintained list that can drift again. rebound and munkres each layer a per-libc include: override (test environment/requires/command) on top of the hard-coded list; since the generated matrix entries carry no custom fields, rebound's three overrides move into a per-platform GITHUB_ENV heredoc step (verified byte-for-byte against the original values via a local bash simulation, including that the musllinux test-command's $(python -c ...) survives as literal text rather than being expanded early) and munkres's single test_requires override becomes an inline matrix.platform ternary. vmprof had no override to preserve, just a stale python list and a hard-coded 'manylinux' literal. Verified each via 'pending_versions.py --python-matrix' against its own docs/packages/<pkg>.yaml before and after: vmprof now covers cp310-cp315 (all manylinux, matching the closed #4913), munkres covers cp310-cp314 across both platforms (matching #4912), rebound covers cp310-cp314t across both platforms (matching #4911) - all libc/matrix.libc references renamed to platform/matrix.platform to match the generated matrix's field name throughout.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the now-closed PRs #4911/#4912/#4913, which each widened a hard-coded
python/libcmatrix to add the missing interpreters those packages'docs/packages/<pkg>.yamlalready declared. That fixed the symptom but left the structural duplication in place (a second, independently-maintained interpreter list that can drift out of sync with the YAML again).This instead converts all three
build_wheelsjobs toinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}, the pattern most otherbuild-<pkg>.ymlfiles already use, which is generated directly from each package's owndocs/packages/<pkg>.yamlfiles:entries - eliminating the possibility of this class of bug for these three going forward.rebound and munkres each layer a per-libc
include:override on the old hard-coded matrix (test environment/requires/command). Since the generated matrix carries no custom fields, these overrides are preserved as:test_requiresstring, converted to an inlinematrix.platform == 'musllinux' && ... || ...ternary.$(python -c ...)substitution - moved into a per-platformGITHUB_ENVheredoc step instead of an inline ternary, to avoid fragile quote-escaping in a GHA expression. Verified byte-for-byte against the original values via a local bash simulation of both branches (including that the musllinux command's$(python -c ...)text survives literally rather than being expanded early).vmprof had no override to preserve, just a stale
pythonlist and a hard-codedmanylinuxliteral.Verified each via
pending_versions.py --python-matrix --python-exclude cp39 <pkg>against its owndocs/packages/<pkg>.yaml:All
matrix.libcreferences renamed tomatrix.platformthroughout (job names,CIBW_BUILD, artifact names) to match the generated matrix's field name.