Repository navigation
Conversation
Old hardcoded python: [cp312, cp313, cp314, cp314t] x libc: [manylinux, musllinux] never matched docs/packages/atomic-dict.yaml: it built orphan cp312/cp314t combos nothing publishes, while never building the cp310 manylinux wheel 0.5.0 actually needs. The matrix conversion fixes this as a side effect.
Old hardcoded python: [cp312, cp313, cp314, cp314t] never built cp310/cp311, which docs/packages/bitstruct.yaml declares for both pending versions, nor cp315/cp315t, which it also now declares.
Adds python-exclude: 'cp39 cp310 cp311' to setup to preserve the file's own deliberate cp312 floor (docs/packages/can-ada.yaml declares cp310/cp311 targets that the generated matrix would otherwise start building).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hardcoded
python:/libc:matrix arrays inbuild_wheels(orthe equivalent build job) with
include: ${{ fromJSON(needs.setup.outputs.matrix) }},and renames the remaining
matrix.libcreferences tomatrix.platformtomatch the generated matrix's field names.
matrix.pythonandmatrix.versionare untouched.
Packages touched (14):
Skipped
build_wheelsjob builds a singleuniversal
py3-nonewheel (hardcodedonly: cp312-manylinux_riscv64, nomatrix.python/matrix.libcat all) and its separatetest_wheeljob hasits own hand-picked, build-unrelated test matrix (
python: ["cp313", "cp314", "cp314t"], deliberately excludingcp312since that interpreteris already exercised by the build). Neither shape matches what
needs.setup.outputs.matrixrepresents (one entry per buildpython/platform combo), and
test_wheel's list already includescp314t,which isn't even a declared target in
docs/packages/audiostretchy.yaml.Converting it would change test coverage in ways outside this mechanical
refactor's scope, so I left it as-is.
Pre-existing stale-matrix mismatches found (step 4)
Verified each file's old hardcoded python/libc list against
uv run --quiet ci_scripts/pending_versions.py --python-matrix --python-exclude cp39 <pkg>for the currently pending version(s). Several files had drifted out ofsync with
docs/packages/<pkg>.yaml, same class of bug as #4914/#4915. Thestructural fix in this PR corrects these as a side effect:
python: [cp312, cp313, cp314](with aper-version
excludefor 2.61.0 dropping cp313/cp314) never built cp310 orcp311 at all.
docs/packages/apache-beam.yamldeclares cp310/cp311 targetsfor every pending version (2.61.0, 2.75.0, 2.76.0, 2.77.0) — this PR starts
building them.
python: [cp312, cp313, cp314, cp314t] x libc: [manylinux, musllinux]both built orphan combos nothing indocs/packages/atomic-dict.yamldeclares (cp312 and cp314t, for eitherplatform) and never built the cp310-manylinux wheel 0.5.0 actually needs.
python: [cp312, cp313, cp314, cp314t]neverbuilt cp310/cp311, which both pending versions (8.23.0, 8.24.0) declare, nor
cp315/cp315t, which both versions now also declare.
python: [cp312, cp313, cp314, cp314t]never builtcp310/cp311, which the pending version (2.1.8) declares.
python: [cp312, cp313, cp314]never built cp310/cp311, which the pending version (1.0.2.6) declares.
python: [cp312, cp313, cp314, cp314t]neverbuilt cp310/cp311, which the pending version (2025.10.22) declares.
python: [cp312, cp313, cp314]never builtcp310/cp311, which the pending version (21.0.0) declares; it also built an
orphan cp314 combo that
docs/packages/coincurve.yamlnever declares for21.0.0 (no wheel for it exists to publish), which this PR stops building.
python: [cp312, cp313, cp314, cp314t]never built cp311, which the pending version (1.1.0) declares.
No mismatch was detectable for aiocsv or annotatedyaml — both
currently have no pending version (
pending_versions.pyreturns[]), sothere's nothing to compare against right now; the conversion is still
structurally correct for whenever a new version lands.
Exclusion preserved (step 5)
free-threaded wheel; floor is our own cp312") documents a deliberate choice
to not build cp310/cp311, beyond the standard
python-exclude: 'cp39'default.
docs/packages/can-ada.yamldoes declare cp310/cp311 targets forthe pending version (3.0.0), so without an explicit exclude this PR's
conversion would silently start building interpreters the port's own
comment says it doesn't want. Added
python-exclude: 'cp39 cp310 cp311'tothe
setup:job'swith:block to preserve that decision.No other file in this batch had a comment indicating a deliberate
cp310/cp311 (or similar) exclusion — grepped all 14 files for
floor,cp310,cp311,excludeto confirm.