Repository navigation
Conversation
Both build_wheels jobs now source their interpreter/platform axis from the shared setup job's generated matrix instead of a hardcoded python (and libc) list. demoparser2: drops the explicit python list and the cp314t test_skip include; adds python-exclude: 'cp39 cp310 cp311' to the setup job so the generated matrix keeps matching this workflow's own cp312+ scope. docs/packages/demoparser2.yaml declares no 3.14t file target, so the generated matrix never produces a cp314t leg either (and the CIBW_TEST_SKIP workaround that leg alone needed goes with it). ormar-utils: drops the explicit python/libc lists; adds python-exclude: 'cp39 cp310 cp311' to the setup job so the abi3-floor selection still lands on cp312 (this workflow's own established floor) rather than the cp310 the generated matrix would otherwise pick from pyo3's unconditional abi3-py310 floor. cp314t stays absent the same way as demoparser2: no 3.14-abi3/3.14t target is declared. grpcio is left unconverted; see the PR description.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide migration of
build-<pkg>.ymlworkflows off their own hardcoded interpreter lists ontoneeds.setup.outputs.matrix(_setup.yml's generatedinclude:-ready matrix, derived from each pending version'sdocs/packages/<pkg>.yamlfiles:entries). This batch owns 3 maturin/PyO3 (Rust) based files; seeskills/python-project-porting/for the general playbook these builds otherwise follow.Converted
build-demoparser2.ymlbuild_wheels.strategy.matrixnow hasinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}as its sole key, replacingversion:+python: ["cp312","cp313","cp314","cp314t"]+ theinclude:entry that settest_skip: "*"forcp314t.matrix.pythonforCIBW_BUILD's interpreter component and both artifact names;matrix.platformforCIBW_BUILD's libc component and the artifact names (always resolves tomanylinux, matching the old hardcoded "manylinux_riscv64" literal —docs/packages/demoparser2.yamldeclares no musllinux target for any version).CIBW_TEST_SKIP: ${{ matrix.test_skip }}is removed outright: withcp314tgone from the matrix (see mismatch below) there is no leg left that ever sets it.python-exclude: 'cp39 cp310 cp311'to thesetupjob.docs/packages/demoparser2.yamldeclares3.10/3.11file targets (riscv64-buildable, not excluded by_setup.yml's owncp39default), but this workflow's hardcoded list never built them — onlycp312+. The added exclusions keep that scope.cp314twas in the old hardcoded list, butdocs/packages/demoparser2.yamldeclares no3.14tfile target for any version, soneeds.setup.outputs.matrixcan never produce acp314tentry — converting drops that leg. Checkingci_scripts/update_doc.py's publish-time validation (merge_publication_files), acp314twheel was already guaranteed to fail publish before this change too: its parsed target (3.14t:manylinux) isn't in the version's declaredfiles:list either, soupdate_doc.py --validate-onlyraisesbuilt wheels have undeclared python targets: ...regardless of the build_wheels matrix shape. So thecp314tleg was pre-existing dead weight on the publish side; this conversion just stops building it. Ifcp314tsupport is still wanted,docs/packages/demoparser2.yamlneeds a3.14t:manylinuxfiles entry added first — out of scope here (workflow-only PR).uv run ci_scripts/pending_versions.py --python-matrix --python-exclude 'cp39 cp310 cp311' demoparser2: produces exactlycp312/cp313/cp314× manylinux for both pending versions (0.42.0,0.42.1), matching the old hardcoded scope minus the deadcp314tleg.build-ormar-utils.ymlbuild_wheels.strategy.matrixnow hasinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}as its sole key, replacingversion:+python: ["cp312"]+libc: [manylinux, musllinux].matrix.pythonforCIBW_BUILD's interpreter component and both artifact names;matrix.platformin place of the oldmatrix.libceverywhere (samemanylinux/musllinuxvalues, renamed to match the generated matrix's field).python-exclude: 'cp39 cp310 cp311'to thesetupjob. ormar-utils'Cargo.tomlcarries pyo3's abi3 floor atpy310, so the un-excluded generated matrix would pickcp310(the oldest riscv64-buildable interpreter at or above that floor) as the build interpreter; this workflow's own comment establishedcp312as the real floor instead. The added exclusions make the generated matrix pickcp312the same way.cp314trequires no exclusion:docs/packages/ormar-utils.yamldeclares no3.14-abi3/3.14ttarget at all (only3.10-abi3), soneeds.setup.outputs.matrixnever produces that leg — same situation as demoparser2, not a new issue introduced here.uv run ci_scripts/pending_versions.py --python-matrix --python-exclude 'cp39 cp310 cp311' --glob '0.2.1' ormar-utils: producescp312× {manylinux, musllinux} withwheel-tag: cp310-abi3, matching the old hardcodedpython: ["cp312"]/libc: [manylinux, musllinux]exactly (no currently-pending version to verify against directly —ormar-utilshas none right now — so--globwas used to force the one declared version through the matrix generator).Skipped
build-grpcio.yml— left unconverted, per the task's own flag to be careful here rather than guess.build_wheels.strategy.matrixtoday has no platform/libc dimension at all:CIBW_BUILD: ${{ matrix.python }}-manylinux_riscv64hardcodesmanylinux, and there's noCIBW_MUSLLINUX_RISCV64_IMAGE, no musllinux-awareCIBW_CONTAINER_ENGINE/ccache wiring, etc. Butdocs/packages/grpcio.yamldeclares amusllinuxtarget for essentially everypythonentry of every version (pending, nofilenameever recorded). Converting straight toinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}would silently double the matrix and start attempting real musllinux builds of a large C++ project (480-minute timeout already, vendored boringssl/abseil/re2, apk-vs-yumCIBW_BEFORE_ALL, ccache paths) that this workflow was never resourced or tested for — a scope change well beyond "source the interpreter axis from the generated matrix," and not something I can verify safely without actually running the musllinux leg.The version-exclude logic (
1.65.5has nocp313/cp314) converts cleanly on its own —docs/packages/grpcio.yaml's1.65.5entry simply has no3.13/3.14file targets, so the generated matrix naturally omits them for that version already, no explicitexclude:needed. It's only the manylinux-only restriction that doesn't have a clean mapping onto the generated matrix (which carries both platforms) without either filtering the matrix in a bespoke way (no precedent for that elsewhere in the repo) or adding a musllinux build path, neither of which I want to force through here.Hard rules followed
fix/matrix-maturin-2branch offmain), no force-push, no merge..github/workflows/*changes only —docs/packages/*.yaml,.queue.yml,skills/untouched.Ludovic Henry <git@ludovic.dev>, no AI/Claude attribution anywhere.