Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 6/8 of the repo-wide migration off hardcoded
strategy.matrixpython:/libc:arrays onto_setup.yml'sneeds.setup.outputs.matrix(same bug class as #4914/#4915).Packages touched (one commit each):
For every file:
strategy.matrixis nowinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}(dropped the separateversion:/python:/libc:arrays), and every remaining${{ matrix.libc }}inbuild_wheels(jobname:,CIBW_BUILD/only:, artifactname:) is renamed to${{ matrix.platform }}.gpl_sourcesjobs (pymetis, pysjef) andpublishjobs were untouched except where noted below.Verified mismatches (step 4)
Ran
uv run --quiet ci_scripts/pending_versions.py --python-matrix --python-exclude cp39 <pkg>for each package and compared against the old hardcodedpython:/libc:lists for the currently-pending version(s). Every one of the 14 files had a real, pre-existing stale-matrix bug, all the same shape: the hardcoded lists were pinned atcp312+when the ports were first authored, whiledocs/packages/<pkg>.yamlhas since grown earlier pending entries (cp310/cp311, sometimes with no filename yet) that the hardcoded lists never built, while in several cases the old lists also kept trying to buildcp314/cp314tcombinations the YAML doesn't even declare. The structural fix resolves all of these as a side effect. Highlights:cp315:manylinux— a wheel the old hardcoded list (cp310-cp314) could never build. These two versions could never have completed/published under the old matrix; they were also wastefully rebuildingcp310-cp314(already published) every run.docs/packages/pynng.yamldoes declare musllinux targets (andcp310/cp311), so per the playbook this conversion now attempts musllinux for the first time. Added the missingMUSLLINUX_RISCV64_IMAGE/CIBW_MUSLLINUX_RISCV64_IMAGEwiring and generalized thepublishjob'sartifact-pattern(was hardcoded to*-manylinux_riscv64). Flagging: the musllinux cffi gap noted in the old comment may still be real — first CI run should be watched, it may need a follow-up if those legs fail.cp312-cp314) was missingcp311, which the YAML does declare pending.cp314texclusion ("upstream ships no free-threaded wheel"). In both casesdocs/packages/<pkg>.yamlsimply never declares a3.14ttarget, so the generated matrix already omits it with nopython-excludeoverride needed (step 5) — left an updated comment explaining this. Both were also missingcp311, which their YAMLs declare pending.3.14ttarget at all, so nopython-excludeneeded.cp310/cp311omission (sometimes across multiple pending versions, e.g. pylzss's 0.3.8/0.3.9).No files were skipped. Not waiting on this PR's CI to go green before reporting back, per instructions.