Repository navigation
Conversation
…ython/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/kasa-crypt.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311 (previously unbuilt despite docs/packages/kasa-crypt.yaml declaring them)
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/lcm.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311; drops cp314t (not declared in docs/packages/lcm.yaml for 1.5.2)
…on/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/lhafile.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311; drops cp314 (not declared in docs/packages/lhafile.yaml for 0.3.1)
…on/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/libscrc.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311 (musllinux only where declared); drops cp313/cp314/cp314t (not declared in docs/packages/libscrc.yaml for 1.8.1)
…ython/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/libtorrent.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311; drops cp314 (not declared in docs/packages/libtorrent.yaml for 2.1.1)
…d python/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/line-profiler.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311/cp315 for 5.1.0; drops musllinux entirely for 5.1.0 (not declared in docs/packages/line-profiler.yaml, though a comment there says musllinux is intentionally still built); also fixes a version/python cross-product so 5.0.2 and 5.1.0 no longer share one hardcoded list
…ded python/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/littlefs-python.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311 (no cp314t change, matches existing exclusion)
…oded python/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/memory-allocator.yaml, and renames matrix.libc to matrix.platform to match.
per-version files already encode the 0.2.1 cp312 gap, so the old 'exclude:' stanza is now redundant and dropped
…thon/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/miniupnpc.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311 (manylinux only, matching docs/packages/miniupnpc.yaml); drops cp314/cp314t (not declared)
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/mlx.yaml, and renames matrix.libc to matrix.platform to match.
build_frontend/test_wheels gain cp310/cp311 and (for 0.32.4) cp315/cp315t, and per-version correctness replaces one hardcoded list shared across all pending versions; build_backend is untouched (version-only, no python dimension)
…hon/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/moderngl.yaml, and renames matrix.libc to matrix.platform to match.
fixes a real cross-product bug: the old hardcoded list applied cp314/cp314t to ALL pending versions including 5.12.0, which docs/packages/moderngl.yaml does not declare them for; also adds cp310/cp311 and (for 5.13.0) cp315/cp315t
…/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/mutf8.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311, otherwise unchanged
…oded python/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/mwparserfromhell.yaml, and renames matrix.libc to matrix.platform to match.
drops cp314 (the existing comment already says 'PyPI ships no cp314 wheel either', so the hardcoded list building cp314 anyway was itself a bug this fixes); adds cp310/cp311
…thon/libc
Replaces the hardcoded strategy.matrix python/libc arrays in build_wheels
with include: ${{ fromJSON(needs.setup.outputs.matrix) }}, derived from
docs/packages/nanoarrow.yaml, and renames matrix.libc to matrix.platform to match.
adds cp310/cp311, otherwise unchanged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide migration off hardcoded
strategy.matrixpython/libc arraysonto
needs.setup.outputs.matrix(see_setup.yml,workflow-anatomy.md). Thisbatch covers 14 packages:
For each
build_wheelsjob (and, for mlx,build_frontend/test_wheels), thestrategy.matrixblock's separateversion/python/libcarrays are replacedwith
include: ${{ fromJSON(needs.setup.outputs.matrix) }}, and every remaining${{ matrix.libc }}reference (jobname:, cibuildwheelonly:/CIBW_BUILD,ternary
CIBW_*knobs, andupload-artifactname:) is renamed to${{ matrix.platform }}.${{ matrix.python }}/${{ matrix.version }}areunchanged. No
publishjob in this batch referencesmatrix.libc, so noneneeded updating.
mlx'sbuild_backendjob has no python dimension (onebackend build per version) and is left untouched.
Pre-existing mismatches this surfaces (verified via
uv run ci_scripts/pending_versions.py --python-matrix <pkg>)The structural fix makes
docs/packages/<pkg>.yamlthe sole source of truth forwhich python/platform combos get built, which changes what gets built for most
of these packages (same root cause as #4914/#4915 — a hardcoded list had drifted
out of sync with the YAML). Not fixing the YAMLs themselves here (out of scope
for a
.github/workflows/*-only branch) — just flagging:(declared in the YAML but never built under the old hardcoded cp312+ list).
docs/packages/lcm.yamlfor 1.5.2) even though the workflow has a cp314t-specificgotcha-127 fix (
PYTHON_GIL=1) that becomes dead weight once cp314t drops outof the matrix.
declared), but loses cp313/cp314/cp314t entirely; the YAML only declares up to
3.12 for 1.8.1, far short of the old hardcoded cp312-cp314t list.
musllinux coverage), loses cp314/cp314t (not declared).
exclude:stanza dropping cp312 for 0.2.1 is nowredundant and removed —
docs/packages/memory-allocator.yaml's 0.2.1 entryalready omits cp312 from
files, so the generated matrix excludes itnaturally.
docs/packages/line-profiler.yamldeclares manylinux only (no musllinux at all), even though the workflow has an
explicit comment ("Upstream 5.1.0 added
*-musllinux_*skip list; we buildmusllinux") recording a deliberate choice to keep building musllinux anyway.
After this change, musllinux wheels stop being built for 5.1.0 until the YAML
gains musllinux entries for it. Also fixes a real cross-product bug: 5.0.2 and
5.1.0 were sharing one hardcoded python list regardless of what each version
actually supports.
applied to both pending versions uniformly, even though 5.12.0's YAML entry
doesn't declare cp314/cp314t at all. Also gains cp310/cp311 and, for 5.13.0,
cp315/cp315t.
wheel either", yet the old hardcoded list built cp314 anyway, contradicting its
own comment;
docs/packages/mwparserfromhell.yamlhas no 3.14 entries, so thisfixes that self-contradiction. Also gains cp310/cp311.
build_frontend/test_wheelsgain cp310/cp311 and, for the pending0.32.4, cp315/cp315t; also fixes the same version/python cross-product issue
(one hardcoded list was shared across all three pending versions).
exclusion (YAML doesn't declare it either).
None of these required a
python-excludeaddition on thesetup:job: everycase where the old hardcoded list omitted something is either (a) not declared
in the YAML at all (so the generated matrix already omits it, no action needed
per the structural-fix rule), or (b) the memory-allocator per-version
filesgap, which the generated matrix already encodes correctly.