Repository navigation
Conversation
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/pytomlpp.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list was stale: version 1.0.13 also needs cp310 and cp311 (declared in the YAML), and version 1.1.0 has no cp314/ cp314t targets at all, so the hardcoded list would have built legs that don't correspond to any declared target for that version.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/pyvirtualcam.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314 list was stale: it missed cp310/cp311 manylinux, which the YAML declares for 0.15.0. No cp314t either way, matching the existing comment (upstream ships no free-threaded wheel).
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/quickjs.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list was badly stale for the pending version 1.19.4: the YAML only declares targets through cp312 (cp310/cp311 manylinux, cp312 manylinux+musllinux), so the old matrix both missed cp310/cp311 and tried to build cp313/cp314/cp314t legs with no corresponding declared target at all.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/ruckig.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list was stale: it missed cp310/cp311 manylinux+musllinux, which the YAML declares for 0.19.4.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/secp256k1.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list was badly stale: the YAML declares no cp314/cp314t target at all for 0.14.0, and cp311 has manylinux only (no musllinux), so the old matrix both built legs with no corresponding declared target and missed cp310/cp311 entirely.
This workflow already named its platform axis matrix.platform, so only the strategy.matrix block changes: drop the hardcoded version/python/platform arrays in favor of the matrix _setup.yml already derives from docs/packages/spacy-alignments.yaml. The old cp312/cp313 list was stale: it missed cp310/cp311 (both pending versions) and cp314/cp315 (0.9.3 only), all declared in the YAML.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/spidev.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list was stale: it missed cp310/cp311/cp315 manylinux, all declared in the YAML for version 3.8 (musllinux is only declared for cp312-cp314t, which the old list did cover).
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/sqlcipher3-wheels.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. Two behavior changes fall out of this, both worth a maintainer look: the old list explicitly included cp39 (unlike every other workflow in this batch), so this version stops building cp39 under the repo's default python-exclude: 'cp39' (0.5.7's cp39 wheel is already published, so nothing already released is affected); and the YAML's pending cp314t targets (added after the hardcoded list was written) now get built for the first time.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/sqlcipher3.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list excluded cp39/cp310/cp311, which the YAML has declared (with no filename, i.e. never built) across all three versions, including the two already published (0.6.2, 0.6.3) - so this is a long-standing gap, not something introduced here. This migration starts building cp310/cp311 for the first time (cp39 stays excluded by the repo's default python-exclude); worth a maintainer check that cp310/cp311 actually build before this merges, since there's no comment recording why they were left out originally.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/sslpsk-pmd3.yaml, rename matrix.libc to matrix.platform throughout build_wheels, including the extra manylinux/cp312-only test step's if: condition. The YAML only declares targets through cp312 for 1.0.3 (cp38-cp311 pending/never built, cp312 published); it has no cp313/cp314/cp314t entries at all, so the old list's cp313/cp314 legs (kept despite the existing 'no cp314t: upstream ships no free-threaded wheel' comment) never corresponded to a declared target. This migration naturally drops those two and starts building cp310/cp311, which were excluded without explanation; cp39 stays excluded by the repo default.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/sysv-ipc.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list was stale: it missed cp310/cp311 manylinux+musllinux, which the YAML declares for 1.2.0.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/teptris.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list matched the YAML's declared targets for 0.3.20.0 exactly (cp310/cp311 manylinux+musllinux are also declared, but the port comment doesn't mention them - only the sdist job's python-version pin and the YAML's requires-python note cp310+, so cp310/cp311 were simply never added to the hardcoded list). This migration starts building them for the first time.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/tesserocr.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list excluded cp39/cp310/cp311, which the YAML has declared (with no filename, i.e. never built) across both versions, including the already-published 2.11.0 - a long-standing gap, not something introduced here. This migration starts building cp310/cp311 for the first time (cp39 stays excluded by the repo's default python-exclude), and also picks up cp315/cp315t for the 2.12.0 version. Worth a maintainer check that cp310/cp311 actually build, since there's no comment recording why they were left out.
Drop the hardcoded python/libc strategy arrays in favor of the version/python/platform matrix _setup.yml already derives from docs/packages/tgcrypto.yaml, and rename matrix.libc to matrix.platform throughout build_wheels. The old cp312-cp314t list was stale: it missed cp310/cp311 manylinux+musllinux, which the YAML declares for 1.2.5.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide cleanup to stop hardcoding
python/libcstrategy arrays inbuild-<pkg>.yml'sbuild_wheelsjob and useneeds.setup.outputs.matrix(already computed by_setup.ymlstraight from each package'sdocs/packages/<pkg>.yaml) instead. Same shape as #4914/#4915.For each file: replaced
strategy.matrixwithinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}(dropping the separateversion/python/libcarrays), and renamed every remainingmatrix.libctomatrix.platforminbuild_wheels(jobname:, cibuildwheelonly:/CIBW_BUILD, artifactname:, and any stepif:conditions).Packages touched (one commit each): pytomlpp, pyvirtualcam, quickjs, ruckig, secp256k1, spacy-alignments, spidev, sqlcipher3-wheels, sqlcipher3, sslpsk-pmd3, sysv-ipc, teptris, tesserocr, tgcrypto.
Verification: for each package, ran
uv run --quiet ci_scripts/pending_versions.py --python-matrix --python-exclude cp39 <pkg>(matching_setup.yml's defaultpython-exclude: 'cp39') and compared the resulting python/platform combinations against what the old hardcodedpython:/libc:lists would have produced for the currently pending version(s).build-spacy-alignments.ymlalready named its platform axismatrix.platform, so only itsstrategy.matrixblock needed replacing.Pre-existing stale-matrix mismatches found (fixed as a side effect of the structural change, same bug class as #4914/#4915):
cp312-cp314tlist missedcp310/cp311(declared for 1.0.13) and triedcp314/cp314tlegs that don't exist for 1.1.0.cp312-cp314list missedcp310/cp311manylinux (declared for 0.15.0).cp312-cp314tlist was badly stale — 1.19.4's YAML only declares targets throughcp312;cp313/cp314/cp314thave no declared target at all, andcp310/cp311were missing.cp312-cp314tlist missedcp310/cp311(declared for 0.19.4).cp312-cp314tlist was badly stale — 0.14.0's YAML declares nocp314/cp314ttarget at all,cp311is manylinux-only, andcp310/cp311were missing.cp312/cp313list missedcp310/cp311(both pending versions) andcp314/cp315(0.9.3 only).cp312-cp314tlist missedcp310/cp311/cp315manylinux (declared for 3.8).cp39(unlike every other file in this batch) and excludedcp314t. After this change,cp39stops being built under the repo's defaultpython-exclude: 'cp39'(0.5.7's cp39 wheel is already published, so nothing already-released is affected), and the YAML's pendingcp314ttargets get built for the first time. Flagging for a maintainer look given the cp39 behavior change.cp312-cp314tlist excludedcp39/cp310/cp311, which the YAML has declared with no filename (never built) across all three versions — including the two already-published ones (0.6.2, 0.6.3). This migration starts buildingcp310/cp311for the first time (no comment records why they were originally left out). Flagging for a maintainer look — worth confirmingcp310/cp311actually build before merging.cp312for 1.0.3; it has nocp313/cp314/cp314tentries despite the old list building them (its "no cp314t" comment undersold how stale the list was). This migration drops those unused legs and starts buildingcp310/cp311, previously excluded without explanation.cp312-cp314tlist missedcp310/cp311(declared for 1.2.0).cp312-cp314tlist missedcp310/cp311, both declared for 0.3.20.0.cp39/cp310/cp311declared with no filename across both versions (including already-published 2.11.0), nowcp310/cp311start building for the first time; also newly picks upcp315/cp315tfor 2.12.0. Flagging for a maintainer look oncp310/cp311.cp312-cp314tlist missedcp310/cp311(declared for 1.2.5).No files outside
.github/workflows/*were touched. Not waiting on this PR's CI to go green before reporting it as opened.