Repository navigation
Conversation
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
Drop the hardcoded python/libc strategy matrix in favor of needs.setup.outputs.matrix, and rename remaining matrix.libc references to matrix.platform.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide move off hardcoded
python/libcstrategy matrices andonto
needs.setup.outputs.matrix(see PRs #4914/#4915 for the bug class thiscloses: a hardcoded list drifting out of sync with
docs/packages/<pkg>.yaml).Packages touched in this batch (14):
For each file: the
build_wheelsjob'sstrategy.matrixnow readsinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}instead of a hardcodedversion/python/libccross product, and every remainingmatrix.libcreference (job
name:, cibuildwheelonly:/CIBW_BUILD:, artifactname:) is renamed tomatrix.platformto match the generated matrix'sfield.
endecandevtxalready usedplatformas the field name, so onlytheir matrix block changed.
Several packages declare interpreters in
docs/packages/<pkg>.yamlthat theirold hardcoded list never built (the repo's actual floor is cp312; cp39-cp311
and, where present, cp315/cp315t are declared for upstream-compat reasons but
never released). Without correcting for that, the generated matrix would
start building those for the first time. To preserve the old, intentional
behavior, each
setup:job now also setspython-excludeto the equivalentof what the old hardcoded list excluded by omission:
crosshair-tool,ct3,cyscale,cyseq,datasketches,dukpy,ed25519-blake2b-fork,edlib,endec,ephem,evtx,fast-diff-match-patch:python-exclude: 'cp39 cp310 cp311'(pluscp315*for
crosshair-tool, which also declares3.15).cysignals:python-exclude: 'cp39 cp315*'— cp312 is already excludednaturally (1.13.0+ raised
requires-pythonto>=3.13, and the YAML stopsdeclaring cp312 from 1.13.0 on), but 1.13.1 newly declares
3.15/3.15t.deflate,evtx: both build an abi3 wheel on the repo's cp312 floor ratherthan on the abi3 floor's own interpreter (3.11 / 3.10); excluding
cp310/cp311 makes the generated matrix's abi3-floor selection land on cp312
too, matching the old
python: [cp312, cp314t]/cp31?-glob behavior.evtx'sCIBW_BUILDternary mapping'abi3' -> 'cp31?'is no longerneeded and was dropped, since the generated matrix's
pythonfield isalready the resolved build interpreter.
Verified each file's new matrix against
uv run --quiet ci_scripts/pending_versions.py --python-matrix --python-exclude '<same exclude>' <pkg>and confirmed it reproduces the old hardcoded python/platform combinations
for the currently pending version(s), with three exceptions — pre-existing
stale-matrix bugs (same shape as #4914/#4915), fixed here as a side effect of
the structural change, flagged for visibility:
cp314t, butdocs/packages/ct3.yamlnever declares a3.14ttarget for3.4.0.post5.That build identifier was being requested every run for nothing; the
generated matrix correctly drops it.
cp314/cp314t, butdocs/packages/datasketches.yamlonly declares up to3.13for5.2.0.Same dead-build-identifier shape; the generated matrix drops both.
cp314/cp314t, butdocs/packages/edlib.yamlonly declares up to3.13for1.3.9.post1.Same shape; dropped.
cp313/cp314/cp314t, butdocs/packages/fast-diff-match-patch.yamlonly declares up to
3.12for2.1.0. Same shape; dropped.No file in this batch was skipped — all 14 convert cleanly to the shared
shape. None of them currently declare any
musllinux-only-new target (allalready built both platforms where applicable), so no package starts
building musllinux for the first time here.
Scope:
.github/workflows/*only, per batch instructions — nodocs/packages/*.yaml,.queue.yml, orskills/changes.