Repository navigation
Conversation
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/ncompress.yaml's files: entries, and renames matrix.libc to matrix.platform to match its field names. The old hardcoded list (cp312, cp314t) was stale: it never built the cp310/cp311 non-abi3 targets the YAML declares, and built cp314t, which the YAML does not declare at all. The generated matrix fixes both as a side effect.
Drops the hardcoded python matrix in favor of the matrix _setup.yml already derives from docs/packages/ngt.yaml's files: entries. No libc dimension existed (manylinux-only), so nothing to rename. The old hardcoded list (cp312, cp313, cp314, cp314t) matches the generated matrix exactly for the current release; no mismatch found.
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/openstep-plist.yaml's files: entries, and renames matrix.libc to matrix.platform. The old hardcoded list (cp312-cp314t) was stale: it never built the cp310/cp311 targets the pending 0.5.2 release declares. Fixed as a side effect of the structural change.
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/pcapy-ng.yaml's files: entries, and renames matrix.libc to matrix.platform. The old hardcoded list (cp312-cp314) was stale: it never built the cp310/cp311 targets the pending 2.1.0 release declares. Its cp314t exclusion needed no equivalent python-exclude, since the YAML never declares a 3.14t target for pcapy-ng at all.
Drops the hardcoded python matrix and its version-keyed exclude list in favor of the matrix _setup.yml already derives from docs/packages/pemja.yaml's files: entries. No libc dimension existed. The old hardcoded list (cp312-cp314t, minus cp313/cp314/cp314t for 0.5.7) was stale for every pending version: it never built the cp310/cp311 targets any of 0.5.7/0.6.2/0.6.3 declare, and for 0.6.3 it targeted cp314/cp314t instead of the cp315t the YAML actually declares. Fixed as a side effect of the structural change.
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/polyscope.yaml's files: entries, and renames matrix.libc to matrix.platform. The old hardcoded list (cp312-cp314t) was stale: it never built the cp310/cp311 targets the pending 2.6.1 release declares. Fixed as a side effect of the structural change.
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/posix-ipc.yaml's files: entries, and renames matrix.libc to matrix.platform. The old hardcoded list (cp312-cp314t) was stale in both directions for the pending 1.3.2 release: it never built the cp310/cp311 targets the YAML declares, and attempted cp314/cp314t targets the YAML does not declare at all. Fixed as a side effect of the structural change.
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/potpourri3d.yaml's files: entries, and renames matrix.libc to matrix.platform, including in the CIBW_BEFORE_ALL_LINUX conditional. The old hardcoded list (cp312-cp314t) was stale: it never built the cp310/cp311 targets the pending 1.4.0 release declares. Fixed as a side effect of the structural change.
…trix Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/private-attribute-cpp.yaml's files: entries, and renames matrix.libc to matrix.platform. The old hardcoded list (cp312-cp314t) was badly stale: all 13 pending versions (2.1.17 through 2.2.7) declare cp310, cp311, cp313t, cp315 and cp315t targets that the hardcoded matrix never built. Fixed as a side effect of the structural change.
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/py-radix.yaml's files: entries, and renames matrix.libc to matrix.platform. The old hardcoded list (cp312-cp314t) was stale: it never built the cp310/cp311 targets the pending 1.1.0 release declares. Fixed as a side effect of the structural change.
Drops the hardcoded python/libc matrix in favor of the matrix _setup.yml already derives from docs/packages/pycapnp.yaml's files: entries, and renames matrix.libc to matrix.platform. The old hardcoded list (cp312-cp314t) was stale: it never built the cp310/cp311 targets the pending 2.2.4 release declares. Fixed as a side effect of the structural change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide move off hardcoded
python:/libc:build matrices andonto
needs.setup.outputs.matrix, which_setup.ymlalready derivesdirectly from each pending version's
docs/packages/<pkg>.yamlfiles:entries. This is batch 5/8, covering 14 packages.
Converted (11)
Each
build_wheelsjob'sstrategy.matrixbecomesinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}, and every remainingmatrix.libcreference in that job is renamed tomatrix.platform(jobname:,CIBW_BUILD/only:, upload-artifactname:, and any inlineexpression using it).
[cp312, cp314t]never builtthe
cp310/cp311targets the pending 1.0.2 release declares, and builtcp314t, which the YAML doesn't declare at all (the single abi3 build is atcp312-abi3). Fixed as a side effect.cp312-cp314t, manylinux-only); no libc dimensionexisted, nothing to rename. No version is currently pending.
cp310/cp311for the pending 0.5.2release. Fixed as a side effect.
cp310/cp311for the pending 2.1.0release. Its
cp314texclusion (comment: no free-threaded wheel upstream)needed no
python-exclude, since the YAML never declares a3.14ttargetfor this package at all.
cp310/cp311forall three pending versions (0.5.7, 0.6.2, 0.6.3), and for 0.6.3 the old
array targeted
cp314/cp314twhile the YAML actually declarescp315t.Dropped the now-redundant per-version
exclude:block too (0.5.7's gap isalready implied by its YAML
files:).cp310/cp311for the pending 2.6.1release.
cp310/cp311, andthe old array also targeted
cp314/cp314t, which the YAML does notdeclare for 1.3.2 at all.
cp310/cp311for the pending 1.4.0release. Also renamed
matrix.libcinside theCIBW_BEFORE_ALL_LINUXternary expression.
pending versions (2.1.17 through 2.2.7) declare
cp310,cp311,cp313t,cp315andcp315ttargets that the hardcoded[cp312-cp314t]array neverbuilt.
cp310/cp311for the pending 1.1.0release.
cp310/cp311for the pending 2.2.4release.
(The
cp310/cp311gap above is the same shape in every case: these twointerpreters became available after each workflow's matrix was authored and
the hardcoded arrays were never updated to match.)
Left unconverted (3) — flagged for manual follow-up
structural change can't carry over mechanically:
cp314tis excluded onlyfor 1.30.0/1.31.0/1.31.1 (documented heap-corruption SIGABRT), not for
1.29.0.
python-excludeon thesetup:job is global to the whole run, notper-version, and GitHub Actions'
exclude:is applied beforeinclude:ismerged in, so it can't filter combinations that come purely from
include:. Naively converting would either silently re-enable the crashingcp314tbuild for the three bad versions, or (with a blanketpython-exclude: cp314t) wrongly dropcp314tfrom 1.29.0, where itbuilds and tests fine. Separately, the YAML also declares
cp311andcp313ttargets for every version that the hardcoded array neverattempted, with no comment explaining why — also needs a maintainer call.
Left as-is rather than guessing.
build_wheels'strategy.matrixhasonly
version:, nopython:/libc:array to replace — it builds a singlehardcoded
cp310-abi3-manylinuxwheel via job-levelPYDIR/WHEEL_TAGenvvars rather than a cibuildwheel matrix.
test_wheels'python: [cp310, cp312, cp313, cp314]matrix is a separate ABI-compatibility test sweepacross every interpreter, not a per-interpreter build axis, so it isn't the
duplication this migration targets either. Left both unconverted.
Non-standard: the old matrix has no
libc:dimension at all, andonly: ${{ matrix.python }}-manylinux_riscv64hardcodes the literal stringmanylinux_riscv64rather than referencing a matrix field — pandascurrently builds manylinux only. But
docs/packages/pandas.yamldoesdeclare musllinux targets for every pending version, so a mechanical
conversion would silently start building musllinux wheels for pandas for
the first time. The workflow's
env:block also only definesMANYLINUX_RISCV64_IMAGE, with noMUSLLINUX_RISCV64_IMAGEforCIBW_MUSLLINUX_RISCV64_IMAGEto reference — building musllinux as-iswould likely fail outright. Given pandas's blast radius (many dependents),
this needs a deliberate, tested change rather than a mechanical one. Left
unconverted.
Verification
For each converted package, ran
uv run --quiet ci_scripts/pending_versions.py --python-matrix --python-exclude cp39 <pkg>and compared the(python, platform)pairs per pending version against what the oldhardcoded
python:/libc:lists would have produced, as described above.Also confirmed no
.github/workflows/*.ymlfile in this branch has alingering
matrix.libcreference, and that all 14 touched files still parseas valid YAML.
No
docs/packages/*.yaml,.queue.yml, orskills/changes in this branch.