Repository navigation
Conversation
…ts.matrix Replace the hardcoded python/libc matrix in build_wheels (and freeze-core's test_wheels) with needs.setup.outputs.matrix for fastparquet, freeze-core, geventhttpclient, gmpy2, gseapy and hierarchicalforecast, converting each file's extra include: override into an inline matrix-field ternary at its point of use: - fastparquet, geventhttpclient, gmpy2, gseapy: cp314t -> CIBW_TEST_SKIP: '*' - hierarchicalforecast: cp312/cp313 -> CIBW_TEST_REQUIRES statsforecast, cp314 -> CIBW_TEST_COMMAND --ignore flags, cp314t -> CIBW_TEST_SKIP: '*' - freeze-core test_wheels: the python -> python-version include block is dropped outright, since needs.setup.outputs.matrix already carries python-version matrix.libc is renamed to matrix.platform throughout freeze-core (the only one of the six with a libc axis); its build_wheels job already builds both platforms from matrix.platform, unchanged. Every build_wheels job here hardcodes a manylinux-only cibuildwheel `only:` (or, for freeze-core, iterates both platforms already), so a job-level `matrix.platform == 'manylinux'` filter is added wherever the package's docs/packages/<pkg>.yaml carries musllinux file entries, to stop musllinux matrix rows from silently re-running (and artifact-colliding with) the same manylinux-only build. freeze-core's test_wheels gets the same filter, since it only ever exercised the manylinux wheel. python-exclude is added to each setup job to preserve the prior workflow's narrower python coverage (all six previously built only cp312-cp314t): - fastparquet, gseapy, hierarchicalforecast: 'cp39 cp310 cp311' - geventhttpclient, gmpy2: 'cp39 cp310 cp311 cp315*' - freeze-core: 'cp39 cp311 cp315*' Verified against `ci_scripts/pending_versions.py --python-matrix` for each package: with the exclude lists above, every one now reproduces exactly the old hardcoded python x platform set, except hierarchicalforecast, whose old list also carried a cp314t leg that docs/packages/hierarchicalforecast.yaml has never declared a 3.14t file entry for -- a pre-existing stale-matrix mismatch (same class as #4914/#4915) that this structural change resolves by simply dropping the dead leg.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide migration to
needs.setup.outputs.matrix(same bug class as #4914/#4915: stale hardcodedpython:/libc:matrix lists). This batch covers the 6 files whosebuild_wheelsjob layers a per-python or per-libcinclude:override on top of the hardcoded list, so each override had to be converted into an inline ternary expression at its point of use rather than just swapped forfromJSON(needs.setup.outputs.matrix).Packages touched and how each override was preserved
include: [{python: cp314t, test_skip: '*'}]→CIBW_TEST_SKIP: ${{ matrix.python == 'cp314t' && '*' || '' }}.cp314t -> test_skipshape, same ternary.cp314t -> test_skipshape, same ternary.cp314t -> test_skipshape, same ternary.cp312/cp313 -> test_requires: statsforecast→CIBW_TEST_REQUIRES: ... ${{ contains(fromJSON('["cp312","cp313"]'), matrix.python) && 'statsforecast' || '' }}cp314 -> pytest_args: --ignore=...→ inlined intoCIBW_TEST_COMMAND's tail:${{ matrix.python == 'cp314' && '--ignore=tests/test_evaluation.py --ignore=tests/test_utils.py' || '' }}cp314t -> test_skip: '*'→CIBW_TEST_SKIPternary, same as the others.build_wheelshadlibc: [manylinux, musllinux](no override) — renamed every${{ matrix.libc }}to${{ matrix.platform }}(job name,CIBW_BUILD, artifact name); both platforms still build exactly as before.test_wheelshadinclude: [{python: cpNNN, python-version: 'N.NN'}, ...]— this mapping is already whatneeds.setup.outputs.matrixcarries natively, so the override block was dropped outright rather than converted to a ternary.Platform filtering
Every one of these
build_wheelsjobs (except freeze-core's, which genuinely builds both) hardcodes a manylinux-only cibuildwheelonly:(fastparquet, gmpy2, gseapy, hierarchicalforecast) orCIBW_BUILD(geventhttpclient).needs.setup.outputs.matrixnow also emits musllinux rows whereverdocs/packages/<pkg>.yamldeclares musllinuxfiles:entries (even unfilled/pending ones) — fastparquet, geventhttpclient and gmpy2 all do. Without a filter, those musllinux matrix rows would silently re-run the same hardcoded-manylinux build and then collide on the upload-artifact name with the manylinux row from the same run. Addedmatrix.platform == 'manylinux'to each affected job'sif:(fastparquet, geventhttpclient, gmpy2, freeze-core'stest_wheels, and defensively on gseapy/hierarchicalforecast even though their yaml currently has no musllinux entries at all).python-exclude additions
All six previously hardcoded
python: ["cp312","cp313","cp314","cp314t"]— narrower thanneeds.setup.outputs.matrixwould otherwise produce from each package's yaml. Added to eachsetup:job'swith:to preserve that exact coverage:fastparquet,gseapy,hierarchicalforecast:python-exclude: 'cp39 cp310 cp311'geventhttpclient,gmpy2:python-exclude: 'cp39 cp310 cp311 cp315*'freeze-core:python-exclude: 'cp39 cp311 cp315*'Mismatch found
hierarchicalforecast: the old hardcoded list included a
cp314tleg (withtest_skip: '*', i.e. it built but never tested it), butdocs/packages/hierarchicalforecast.yamlhas never declared a3.14tfile entry for this package at all — so that leg was building an untracked, unpublishable wheel for no reason. Confirmed viauv run --quiet ci_scripts/pending_versions.py --python-matrix --python-exclude 'cp39 cp310 cp311' --glob '*' hierarchicalforecast, whose output tops out atcp314. This is the same stale-matrix bug class as #4914/#4915; the structural fix here resolves it on its own, sincecp314tsimply never appears inneeds.setup.outputs.matrixfor this package.Every other package's
python x platformset, after thepython-excludeadditions above, reproduces the old hardcoded set exactly (verified the same way, per package).Scope
.github/workflows/*only — nodocs/packages/*.yaml,.queue.yml, orskills/changes.