Skip to content

ci: migrate 8 workflows (with per-leg overrides) to needs.setup.outputs.matrix (extra-include batch 4/4) - #4930

Open
luhenry wants to merge 1 commit into
mainfrom
fix/matrix-extra-4
Open

luhenry wants to merge 1 commit into
mainfrom
fix/matrix-extra-4

Conversation

@luhenry

@luhenry luhenry commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Same mechanical fix as #4914/#4915, applied to the 8 workflows in this batch that also layer a per-python or per-libc include: override on top of the hardcoded matrix. Each hardcoded python:/libc: array plus include: block is replaced with matrix: { include: ${{ fromJSON(needs.setup.outputs.matrix) }} }, matrix.libc is renamed to matrix.platform, and every overridden field is converted to an inline ternary at its point of use (the generated entries carry no such fields).

Packages and how each override was preserved

  • pot: extra_deselect (cp314t only) -> matrix.python == 'cp314t' && '--deselect ...' || '' in CIBW_TEST_COMMAND.
  • pyvrp: pytest-args (cp311 only) -> same ternary pattern in CIBW_TEST_COMMAND.
  • regopy: before_all keyed on libc -> matrix.platform == 'manylinux' && 'dnf ...' || 'apk ...' in CIBW_BEFORE_ALL.
  • scikit-learn: two fields keyed on python (pandas, loky_broken) -> contains(fromJSON('[...]'), matrix.python) && ... || '' in CIBW_TEST_REQUIRES / CIBW_TEST_ENVIRONMENT. Flagging this one for a careful look given its downstream impact.
  • snowflake-connector-python: pytest_dist (cp314t vs. rest) -> ternary in CIBW_TEST_COMMAND.
  • statsforecast: test_skip (cp314/cp314t) -> contains(...) && '*' || '' in CIBW_TEST_SKIP.
  • transformations: non-standard shape - python was only a grouping label for a build field spanning multiple literal CIBW_BUILD selectors (one cp312 leg builds+retests cp312/cp313/cp314 abi3, one cp314t leg is free-threaded only). Preserved exactly for those two keys; any other interpreter the generated matrix picks up (currently cp315t) falls back to a plain ${python}-${platform}_riscv64 single-selector build.
  • zuvloop: hypothesis pin (cp314t only) -> ternary in CIBW_TEST_REQUIRES.

Mismatches/exclusions found while verifying against uv run ci_scripts/pending_versions.py --python-matrix <pkg>

  • pot, regopy, snowflake-connector-python, statsforecast: the hardcoded lists always skipped cp310/cp311 beyond the default cp39; added python-exclude: 'cp39 cp310 cp311' to setup: to keep that scope.
  • scikit-learn: hardcoded list always skipped cp311; added python-exclude: 'cp39 cp311'.
  • regopy, statsforecast: both hardcoded cp314t into their matrix even though docs/packages/<pkg>.yaml declares no 3.14t files entry for either. The generated matrix correctly drops that phantom leg - letting the structural fix resolve it rather than reintroducing it.
  • scikit-learn: the fix newly picks up cp311 (now excluded above) and, for 1.9.1, cp315/cp315t, which the stale hardcoded list never saw.
  • pyvrp, zuvloop: neither had a libc/platform axis before (manylinux only, hardcoded), but docs/packages/<pkg>.yaml already declares pending musllinux file entries for every version, so the generated matrix now also attempts musllinux legs. These may not actually build (pyvrp's numpy/matplotlib/contourpy/kiwisolver/pillow pins and zuvloop's native extension may lack riscv64 musllinux wheels/toolchain support) - left for CI to show; each publish: job's artifact-pattern still filters to *-manylinux_riscv64, so a musllinux leg failing or succeeding changes nothing about what gets published.
  • transformations: the fix newly picks up cp315t (see above), previously invisible to the stale ["cp312", "cp314t"] list.

No other files touched.

…ts.matrix

Converts build-pot, build-pyvrp, build-regopy, build-scikit-learn,
build-snowflake-connector-python, build-statsforecast,
build-transformations and build-zuvloop from hardcoded python/libc
matrices plus a layered include: override to the data-driven
needs.setup.outputs.matrix, same as #4914/#4915. Each per-python or
per-libc override (test_skip, test_requires additions, before_all,
before_test, pytest args/dist, build selectors) is preserved as an
inline GitHub Actions ternary at its point of use instead of a matrix
field, since the generated matrix entries do not carry those fields.

Several packages' hardcoded python lists diverged from what
docs/packages/<pkg>.yaml actually declares; python-exclude is added to
setup: where needed to keep excluding tags the old list always skipped
beyond the default cp39.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant