Repository navigation
Conversation
Replace the hardcoded python list (and its include-based per-interpreter test-level mapping) in build_wheels' strategy.matrix with include: fromJSON(needs.setup.outputs.matrix), and source matrix.platform for job/artifact naming instead of a literal "manylinux_riscv64". The per-interpreter test level (full/smoke/none) that used to come from a matrix include is now computed once as a BLASTDNS_TEST env var from matrix.python, preserving the exact cp39/cp310-cp314/cp314t split.
Replace the hardcoded python list and version-keyed exclude (cp39 for 4.12.0/4.12.1/4.12.2) in build_wheels' strategy.matrix with include: fromJSON(needs.setup.outputs.matrix); the exclude is now implicit since those versions' docs/packages/cedarpy.yaml entries never declare a cp39 target. Source matrix.platform for job/artifact naming (always "manylinux" today, matching docs/packages/cedarpy.yaml, which declares no musllinux target).
Replace the hardcoded python/libc cross product (and the orjson include keyed on both) in build_wheels' strategy.matrix with include: fromJSON(needs.setup.outputs.matrix), mapping matrix.libc -> matrix.platform throughout (only:, CIBW_TEST_REQUIRES/CIBW_TEST_COMMAND inline conditions, job name, artifact name). Add python-exclude: 'cp39 cp310 cp311' to the setup job to preserve the prior restriction: the hardcoded list only ever started at cp312, even though docs/packages/chompjs.yaml still declares cp39-cp311 targets.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
build_wheels'strategy.matrixin three maturin/PyO3 workflows from a hardcodedpython:/libc:list toinclude: ${{ fromJSON(needs.setup.outputs.matrix) }}, matching the pattern already used by ~40 other maturin workflows (e.g.build-blasthttp.yml,build-python-flirt.yml).blastdns - dropped the hardcoded
python: [cp39..cp314t]plus itsinclude:-based per-interpretertest(full/smoke/none) mapping.matrix.python/matrix.platformnow come straight from the generated matrix; job/artifact names usematrix.platforminstead of a literalmanylinux_riscv64. The oldtestmapping is now aBLASTDNS_TESTenv var computed frommatrix.python(endsWith(matrix.python, 't')->none,cp310-cp314->full, elsesmoke), preserving the exact existing split while generalizing to any future interpreter the same way the comments already justify (registry gap for non-cp310-314, hard orjson free-threaded incompatibility for any*t). Verified the manylinux combinations anuv run ci_scripts/pending_versions.py --python-matrix blastdns(with the defaultcp39exclude) now produces exactly match the old hardcoded cp310-cp314t list. Two real deltas, not mismatches: (1) version 2.0.2 now also builds cp315/cp315t (docs/packages/blastdns.yaml already declares them, the old hardcoded list predates them); (2) the matrix also carries musllinux rows for every version, since docs/packages/blastdns.yaml declares a:musllinuxtarget for every interpreter - the build step itself is unchanged (still glibc-only viamaturin-action'smanylinux: '2_39'), so those rows build and are named identically to the already-mergedbuild-blasthttp.yml's musllinux rows. This is a pre-existing repo-wide gap (no musl target wiring), not something this PR introduces or fixes.cedarpy - dropped the hardcoded
python: [cp39..cp314t]plus the per-versionexclude:(cp39 on 4.12.0/4.12.1/4.12.2). docs/packages/cedarpy.yaml has no musllinux entries at all, somatrix.platformis alwaysmanylinux; used it anyway for job/artifact naming (matches thebuild-python-flirt.ymlprecedent, which has the same all-manylinux shape). Nopython-exclude:addition needed: those three versions' YAML entries never declare a cp39 target, so the generated matrix already omits it exactly as the oldexclude:did. Verified combinations match.chompjs - this one is cibuildwheel-based (not maturin-action), already had a real
python x libcmatrix plus aninclude:-basedorjsonflag keyed on (python, libc). Mappedmatrix.libc->matrix.platformeverywhere (only:, job name, artifact name) and replaced theorjsoninclude with an inline condition (matrix.platform == 'manylinux' && python in {cp312,cp313,cp314}) in bothCIBW_TEST_REQUIRESandCIBW_TEST_COMMAND. Addedpython-exclude: 'cp39 cp310 cp311'to thesetup:job: the old hardcoded list started at cp312, but docs/packages/chompjs.yaml still declares cp39/cp310/cp311 targets, so without this exclude those three interpreters would start building for the first time. Verified--python-matrix --python-exclude 'cp39 cp310 cp311'produces exactly the old cp312/cp313/cp314/cp314t x manylinux/musllinux cross product (8 entries).No
docs/packages/*.yaml,.queue.ymlorskills/changes.