Repository navigation
feat: Add enableInkbleed param from JS runtime - #449
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The demo reports a successful toggle-off interaction as a failure.
1 open issue
What changed in this PR
Adds opt-in inkbleed support to the React bindings for JS runtime 2.45.0.
Changes:
- Forwards
enableInkbleedand disables offscreen rendering by default when enabled. - Documents renderer compatibility and extends regression coverage.
- Adds an interactive Storybook example.
| File | Description |
|---|---|
| test/useRiveGpuCanvas.test.tsx | Moves existing tests into the main hook suite. |
| test/useRive.test.tsx | Adds inkbleed renderer-resolution tests. |
| src/types.ts | Documents inkbleed renderer defaults. |
| src/hooks/useRive.tsx | Resolves renderer selection and warns on conflicts. |
| src/components/Rive.tsx | Exposes and forwards the inkbleed prop. |
| package.json | Updates runtime dependencies to 2.45.0. |
| package-lock.json | Locks updated runtime packages. |
| examples/src/components/Inkbleed.tsx | Adds an interactive inkbleed demo. |
| examples/src/components/Inkbleed.stories.ts | Registers the demo in Storybook. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the JS runtime to 2.45.0, which adds the new inkbleed opt-in feature. It still remains an opt-in
enableInkbleed?: booleanparam here, and follows similar logic to theenableGPUCanvasflag. This means that settingenableInkbleed: trueon useRive/<Rive />will implicitly setuseOffscreenRenderer: false.